search

eclipse-ee4j / glassfish-hk2

Dynamic dependency injection framework
https://eclipse-ee4j.github.io/glassfish-hk2
Other
84 stars 55 forks source link

Drop `logback` dependencies #996

Closed pzygielo closed 6 months ago

pzygielo commented 6 months ago

These managed dependencies seem to be used only in https://github.com/eclipse-ee4j/glassfish-hk2/blob/8ed1807b41a7e46e8aa251e6c2913ef689bec63a/osgi/adapter-tests/osgi-adapter-test/pom.xml#L183-L190 But the osgi-adapter-test module was removed from the build anyway https://github.com/eclipse-ee4j/glassfish-hk2/blob/8ed1807b41a7e46e8aa251e6c2913ef689bec63a/osgi/adapter-tests/pom.xml#L38

Even if osgi-adapter-test was included - I could not see logback to transit in other version from anything there.

IF re-including osgi-adapter-test in the build would require logback - we could have it back again then.

dmatej commented 6 months ago

Hmmm, I see, will we fix that test?

pzygielo commented 6 months ago

Hmmm, I see, will we fix that test?

The commit says Removed OSGi adapter tests due to usage of pax-exam - I haven't checked all comments in that PR - is it illegal to use pax-exam? Or was is excluded for other reason? No idea.