scrumtoys JSF app is still broken

glassfishrobot commented 14 years ago

does not compile with latest gf v3 b70 (see bean validation apis changes). Also warnings in the NB or Eclipse IDEs.

regarding face-config and

com.sun.facelets.FaceletViewHandler

or

jsfcomps.tld

Need a complete retesting...

Environment

Operating System: All Platform: All

Affected Versions

[javaee6]

glassfishrobot commented 4 years ago

Issue Imported From: https://github.com/javaee/glassfish-samples/issues/21
Original Issue Raised By:@glassfishrobot
Original Issue Assigned To: @glassfishrobot
Original Issue Closed By:@glassfishrobot

glassfishrobot commented 14 years ago

@glassfishrobot Commented Reported by ludo

glassfishrobot commented 14 years ago

@glassfishrobot Commented msreddy said: requesting Jim's help

glassfishrobot commented 14 years ago

@glassfishrobot Commented ludo said: thread with Ed Burns a while back: MK> I see these warnings when deploying on GlassFish:

Ok, there are several small bug fixes that need to be made to ScrumToys. Because globalcode can no longer check into java.net directly due to the remedy we took to solve the DoS attack, I'll check in the fixes for these. I also have an issue to clean this demo up for the Mojarra codebase as well.

https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=1338

Here are the issues we need to fix. How much time do I have to get these into the mojarra source code so that the NetBeans team can pick them up?

1. Add a to the faces-config.xml. The omission of this element causes automatical localization not to work.

2. Fix the warning messages found by Milan

MK> INFO: Initializing Mojarra 2.0.0 (RC b20) for context '/scrumtoys' MK> WARNING: JSF1057: The resource referred to by from-view-id, MK> 'dashboard/show.xhtml', does not start with '/'. This will be added for MK> you, but it should be corrected. MK> WARNING: JSF1057: The resource referred to by from-view-id, MK> 'sprint/show.xhtml', does not start with '/'. This will be added for MK> you, but it should be corrected. MK> WARNING: JSF1057: The resource referred to by from-view-id, MK> 'story/show.xhtml', does not start with '/'. This will be added for MK> you, but it should be corrected. MK> WARNING: JSF1057: The resource referred to by from-view-id, MK> 'task/show.xhtml', does not start with '/'. This will be added for you, MK> but it should be corrected.

MK> Milan

3. Remove the it is not needed in JSF 2.0

LC> Continuing with the thread on scrumtoys, and looking at my Eclipse LC> project for this code, I still see some warnings: LC> LC> 1/ faces-config.xml LC> ... LC> com.sun.facelets.FaceletViewHandler LC> ... LC> This class is not in the project classpath. In which jar it is LC> defined? Why do we need com.sun.* classes for JSF 2.0 app sample?

4. Remove the jsfcomps.tld. It's not needed in JSF 2.0

LC> 2/ jsfcomps.tld: LC> jsf.component.BurndownTagHandler LC> Same here: where is this class? Why is it needed? where is the jar, LC> javadoc?

5. Clean up the typesafety warnings

LC> 3/ java code shows some typesafety warnings with collection usage. No LC> big deal, but annoying when seen in Eclipse.

glassfishrobot commented 14 years ago

@glassfishrobot Commented ludo said: other warnings Eclipse is emitting (no big deal, but...bad for a sample)

Description Resource Path Location Type Invalid location of tag (hr). index.html /scrumtoys/docs line 130 HTML Problem Invalid location of tag (li). index.html /scrumtoys/docs line 120 HTML Problem Invalid location of tag (li). index.html /scrumtoys/docs line 121 HTML Problem Invalid location of tag (ol). index.html /scrumtoys/docs line 118 HTML Problem Invalid location of tag (p). index.html /scrumtoys/docs line 52 HTML Problem Invalid location of tag (p). index.html /scrumtoys/docs line 55 HTML Problem Invalid location of tag (p). index.html /scrumtoys/docs line 59 HTML Problem Invalid location of tag (p). index.html /scrumtoys/docs line 61 HTML Problem Invalid location of tag (p). index.html /scrumtoys/docs line 63 HTML Problem Invalid location of tag (p). index.html /scrumtoys/docs line 117 HTML Problem Invalid location of tag (p). index.html /scrumtoys/docs line 124 HTML Problem Invalid location of tag (p). index.html /scrumtoys/docs line 131 HTML Problem Invalid location of tag (pre). index.html /scrumtoys/docs line 87 HTML Problem No grammar constraints (DTD or XML schema) detected for the document. ant-deploy.xml /scrumtoys/nbproject line 1 XML Problem No grammar constraints (DTD or XML schema) detected for the document. build-impl.xml /scrumtoys/nbproject line 1 XML Problem No grammar constraints (DTD or XML schema) detected for the document. build.xml /scrumtoys line 1 XML Problem No grammar constraints (DTD or XML schema) detected for the document. build.xml /scrumtoys/test line 1 XML Problem No grammar constraints (DTD or XML schema) detected for the document. project.xml /scrumtoys/nbproject line 1 XML Problem Null pointer access: The variable value can only be null at this location ProjectConverter.java /scrumtoys/src/java/jsf2/demo/scrum/web/helper line 22 Java Problem The import java.util.ResourceBundle is never used ProjectManager.java /scrumtoys/src/java/jsf2/demo/scrum/web/controller line 6 Java Problem The import java.util.ResourceBundle is never used SprintManager.java /scrumtoys/src/java/jsf2/demo/scrum/web/controller line 7 Java Problem The serializable class AbstractEntity does not declare a static final serialVersionUID field of type long AbstractEntity.java /scrumtoys/src/java/jsf2/demo/scrum/model/entities line 13 Java Problem The serializable class CurrentProjectChangeEvent does not declare a static final serialVersionUID field of type long CurrentProjectChangeEvent.java /scrumtoys/src/java/jsf2/demo/scrum/web/event line 9 Java Problem The serializable class CurrentSprintChangeEvent does not declare a static final serialVersionUID field of type long CurrentSprintChangeEvent.java /scrumtoys/src/java/jsf2/demo/scrum/web/event line 9 Java Problem The serializable class CurrentStoryChangeEvent does not declare a static final serialVersionUID field of type long CurrentStoryChangeEvent.java /scrumtoys/src/java/jsf2/demo/scrum/web/event line 9 Java Problem The serializable class CurrentTaskChangeEvent does not declare a static final serialVersionUID field of type long CurrentTaskChangeEvent.java /scrumtoys/src/java/jsf2/demo/scrum/web/event line 9 Java Problem The serializable class ProjectChangeListener does not declare a static final serialVersionUID field of type long SprintManager.java /scrumtoys/src/java/jsf2/demo/scrum/web/controller line 233 Java Problem The serializable class SprintChangeListener does not declare a static final serialVersionUID field of type long DashboardManager.java /scrumtoys/src/java/jsf2/demo/scrum/web/controller line 73 Java Problem The serializable class SprintChangeListener does not declare a static final serialVersionUID field of type long StoryManager.java /scrumtoys/src/java/jsf2/demo/scrum/web/controller line 198 Java Problem The serializable class StoryChangeListener does not declare a static final serialVersionUID field of type long TaskManager.java /scrumtoys/src/java/jsf2/demo/scrum/web/controller line 193 Java Problem The static field TaskStatus.DONE should be accessed in a static way Task.java /scrumtoys/src/java/jsf2/demo/scrum/model/entities line 76 Java Problem The static field TaskStatus.TODO should be accessed in a static way Task.java /scrumtoys/src/java/jsf2/demo/scrum/model/entities line 82 Java Problem The static field TaskStatus.WORKING should be accessed in a static way Task.java /scrumtoys/src/java/jsf2/demo/scrum/model/entities line 79 Java Problem The tag handler class for "burndown" (jsf.component.BurndownTagHandler) was not found on the Java Build Path jsfcomps.tld /scrumtoys/web/WEB-INF line 13 JSP Problem Type safety: The expression of type List needs unchecked conversion to conform to List Project.java /scrumtoys/src/java/jsf2/demo/scrum/model/entities line 81 Java Problem Type safety: The expression of type List needs unchecked conversion to conform to List Sprint.java /scrumtoys/src/java/jsf2/demo/scrum/model/entities line 130 Java Problem Type safety: The expression of type List needs unchecked conversion to conform to List Story.java /scrumtoys/src/java/jsf2/demo/scrum/model/entities line 130 Java Problem Type safety: Unchecked cast from List to List ProjectManager.java /scrumtoys/src/java/jsf2/demo/scrum/web/controller line 56 Java Problem Undefined attribute name (width). footer.xhtml /scrumtoys/web line 8 HTML Problem

glassfishrobot commented 14 years ago

@glassfishrobot Commented ludo said: but this one is scary public class ProjectConverter implements Converter {

private static Map<Long, Project> cache = new HashMap<Long, Project>();

public Object getAsObject(FacesContext context, UIComponent component, String value) { if (value == null && value.equals("0"))

{ return null; }

when value==null, you have a npe ready to be fired

glassfishrobot commented 14 years ago

@glassfishrobot Commented driscoll said: This is supposed to be Ed's bug - but he's away, so I'll look at it as soon as I'm able. It may need to wait until Monday, however.

glassfishrobot commented 14 years ago

@glassfishrobot Commented davisn said: For a while, the sample was working ok with the NB bunlded b69 build

glassfishrobot commented 14 years ago

@glassfishrobot Commented msreddy said: Based on the latest glassfish v3 hudson build, I get the following output on client.

munnangi[280]: cd scrumtoys/ munnangi[281]: ant all Buildfile: build.xml [loadfile] /home/sreeni/IAS/SAMPLES/WS/glassfish-samples/ws/javaee6/web/jsf/nbproject/private/private.properties doesn't exist

default-ear:

-pre-compile:

bpp-actual-compilation: [echo] Compiling scrumtoys [mkdir] Created dir: /home/sreeni/IAS/SAMPLES/WS/glassfish-samples/ws/javaee6/web/jsf/scrumtoys/build/classes [javac] Compiling 22 source files to

/home/sreeni/IAS/SAMPLES/WS/glassfish-samples/ws/javaee6/web/jsf/scrumtoys/build/classes [javac]

/home/sreeni/IAS/SAMPLES/WS/glassfish-samples/ws/javaee6/web/jsf/scrumtoys/src/java/jsf2/demo/scrum/model/entities/Sprint

NameUniquenessConstraint.java:45: cannot find symbol [javac] symbol : class Payload [javac] location: package javax.validation [javac] import javax.validation.Payload; [javac] ^ [javac]

/home/sreeni/IAS/SAMPLES/WS/glassfish-samples/ws/javaee6/web/jsf/scrumtoys/src/java/jsf2/demo/scrum/model/entities/Sprint

NameUniquenessConstraint.java:57: cannot find symbol [javac] symbol : class Payload [javac] location: @interface jsf2.demo.scrum.model.entities.SprintNameUniquenessConstraint [javac] Class<? extends Payload>[] payload() default {}; [javac] ^ [javac]

/home/sreeni/IAS/SAMPLES/WS/glassfish-samples/ws/javaee6/web/jsf/scrumtoys/src/java/jsf2/demo/scrum/web/controller/TaskM

anager.java:62: package jsf2.demo.scrum.web.scope does not exist [javac] import jsf2.demo.scrum.web.scope.TaskScopeResolver; [javac] ^ [javac]

/home/sreeni/IAS/SAMPLES/WS/glassfish-samples/ws/javaee6/web/jsf/scrumtoys/src/java/jsf2/demo/scrum/web/controller/SkinM

anager.java:57: cannot find symbol [javac] symbol : class SkinValuesManager [javac] location: class jsf2.demo.scrum.web.controller.SkinManager [javac] private SkinValuesManager skinValuesManager; [javac] ^ [javac]

/home/sreeni/IAS/SAMPLES/WS/glassfish-samples/ws/javaee6/web/jsf/scrumtoys/src/java/jsf2/demo/scrum/web/controller/SkinM

anager.java:77: cannot find symbol [javac] symbol : class SkinValuesManager [javac] location: class jsf2.demo.scrum.web.controller.SkinManager [javac] public SkinValuesManager getSkinValuesManager() { [javac] ^ [javac]

/home/sreeni/IAS/SAMPLES/WS/glassfish-samples/ws/javaee6/web/jsf/scrumtoys/src/java/jsf2/demo/scrum/web/controller/SkinM

anager.java:81: cannot find symbol [javac] symbol : class SkinValuesManager [javac] location: class jsf2.demo.scrum.web.controller.SkinManager [javac] public void setSkinValuesManager(SkinValuesManager skinValuesManager) { [javac] ^ [javac]

/home/sreeni/IAS/SAMPLES/WS/glassfish-samples/ws/javaee6/web/jsf/scrumtoys/src/java/jsf2/demo/scrum/model/entities/Sprint

NameUniquenessConstraintValidator.java:57: cannot find symbol [javac] symbol : class ConstraintViolationBuilder [javac] location: interface javax.validation.ConstraintValidatorContext [javac] ConstraintValidatorContext.ConstraintViolationBuilder builder = [javac] ^ [javac]

/home/sreeni/IAS/SAMPLES/WS/glassfish-samples/ws/javaee6/web/jsf/scrumtoys/src/java/jsf2/demo/scrum/model/entities/Sprint

NameUniquenessConstraintValidator.java:58: cannot find symbol [javac] symbol : method buildConstraintViolationWithTemplate(java.lang.String) [javac] location: interface javax.validation.ConstraintValidatorContext [javac] ctx.buildConstraintViolationWithTemplate(message); [javac] ^ [javac]

/home/sreeni/IAS/SAMPLES/WS/glassfish-samples/ws/javaee6/web/jsf/scrumtoys/src/java/jsf2/demo/scrum/web/controller/TaskM

anager.java:234: cannot find symbol [javac] symbol : variable TaskScopeResolver [javac] location: class jsf2.demo.scrum.web.controller.TaskManager [javac] TaskScopeResolver.destroyScope(); [javac] ^ [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. [javac] 9 errors

BUILD FAILED /home/sreeni/IAS/SAMPLES/WS/glassfish-samples/ws/bp-project/command-line-ant-tasks.xml:81: Compile failed; see the

compiler error output for details.

Total time: 7 seconds munnangi[282]:

glassfishrobot commented 14 years ago

@glassfishrobot Commented driscoll said: Ed, Ryan and I have gone through the code with Netbeans and cleaned up everything we've found there.

There are still a small handful of reported errors - those are either bugs in JSF (2.0.3 will address them), or Netbeans (they've been filed).

Please feel free to reopen this bug if you see any additional problems - everything should run fine now.

glassfishrobot commented 14 years ago

@glassfishrobot Commented Was assigned to driscoll

glassfishrobot commented 7 years ago

@glassfishrobot Commented This issue was imported from java.net JIRA GLASSFISH_SAMPLES-21

glassfishrobot commented 14 years ago

@glassfishrobot Commented Marked as fixed on Wednesday, November 11th 2009, 7:46:29 am

eclipse-ee4j / glassfish-samples

scrumtoys JSF app is still broken #21

Environment

Affected Versions