MultiCastReceiverThread is not clearing buffer in DatagramPacket

eclipse-ee4j / glassfish-shoal

Shoal

Other

5 stars 9 forks source link

MultiCastReceiverThread is not clearing buffer in DatagramPacket #115

Closed glassfishrobot closed 13 years ago

glassfishrobot commented 13 years ago

In the thread's run method, the same byte buffer is being used for each DatagramPacket created. So the data returned from receive method can contain extra text, which throws of the set of host strings. So hosts will show up more than once in the output of the validate multicast tool.

Simple fix is just to create a new byte array for each packet (or clear the old one). Without this fix, the tool still gives accurate results – it can just include extra copies of previous entries. I have a GF issue filed for integration, and this one for the actual fix.

Affected Versions

[current]

glassfishrobot commented 6 years ago

Issue Imported From: https://github.com/javaee/shoal/issues/115
Original Issue Raised By:@glassfishrobot
Original Issue Assigned To: @glassfishrobot
Original Issue Closed By:@glassfishrobot

glassfishrobot commented 13 years ago

@glassfishrobot Commented Reported by bbissett

glassfishrobot commented 13 years ago

@glassfishrobot Commented bbissett said: Fixed in revision 1544.

glassfishrobot commented 13 years ago

@glassfishrobot Commented Issue-Links: blocks GLASSFISH-16108

glassfishrobot commented 13 years ago

@glassfishrobot Commented Was assigned to bbissett

glassfishrobot commented 7 years ago

@glassfishrobot Commented This issue was imported from java.net JIRA SHOAL-115

glassfishrobot commented 13 years ago

@glassfishrobot Commented Marked as fixed on Wednesday, March 2nd 2011, 11:39:27 pm