eclipse-ee4j / glassfish-shoal

Shoal
Other
5 stars 9 forks source link

Change ShoalLogger WARNING for IOException to FINE #73

Closed glassfishrobot closed 14 years ago

glassfishrobot commented 16 years ago

This is a short term change just before a shoal release. Longer term solution is documented in a separate shoal issue. (will link when it is available.)

Currently when there is an IOException from DAS to a server instance that was either killed or server failed to start for some reason (like ORB bind address still in use), it results in a WARNING that does not contain sufficient information for an administrator to know what server instance there was a difficulty sending a message to. Given that the WARNING was occurring for non-error cases and there was not enough info in message for an administrator to easily be able to figure out whether the WARNING is something that requires attention or not. This log event is being reduced to FINE.

When such a message does occur with FINE, here is how one can correlate the failure with a server instance name.

From a server.log, here is an event indicating a failure to send to another server instance in the cluster. From the jxta://uuid-XXX, take the last 6 numbers and search the log for an entry that has a server instance name in it.

[#|2008-07-23T19:44:31.665-0700|WARNING|sun-glassfish-comms-server1.0|javax.enterprise.system.stream.err|_ThreadID=29;_ThreadName=MessageWindowThread;_RequestID=80b25066-a911-401d-b38b-b99a0c3aecc2;|java.io.IOException: Unable to create a messenger to jxta://uuid-0CEC11B5D9E64303A621B9B272CD0439FC9C0AEFDE264179A314B0C0C01C0BF803/PipeService/urn:jxta:uuid-0CEC11B5D9E64303A621B9B272CD04396521C3C52E4443928082812BCDC1E25B04 at net.jxta.impl.pipe.BlockingWireOutputPipe.checkMessenger(BlockingWireOutputPipe.java:238) at net.jxta.impl.pipe.BlockingWireOutputPipe.send(BlockingWireOutputPipe.java:264) at com.sun.enterprise.jxtamgmt.ClusterManager.send(ClusterManager.java:495) at com.sun.enterprise.ee.cms.impl.jxta.GroupCommunicationProviderImpl.sendMessage(GroupCommunicationProviderImpl.java:217) at com.sun.enterprise.ee.cms.impl.jxta.DistributedStateCacheImpl.sendMessage(DistributedStateCacheImpl.java:458) at com.sun.enterprise.ee.cms.impl.jxta.DistributedStateCacheImpl.addAllToRemoteCache(DistributedStateCacheImpl.java:388) at com.sun.enterprise.ee.cms.impl.jxta.MessageWindow.handleDSCMessage(MessageWindow.java:127) at com.sun.enterprise.ee.cms.impl.jxta.MessageWindow.newMessageReceived(MessageWindow.java:107) at com.sun.enterprise.ee.cms.impl.jxta.MessageWindow.run(MessageWindow.java:91) at java.lang.Thread.run(Thread.java:619)

| #] |

Search for BF803, find following log entry that shows that the sendMessage was to server instance

9: MemberId: n2c1m4, MemberType: CORE, Address: urn:jxta:uuid-0CEC11B5D9E64303A621B9B272CD0439FC9C0AEFDE264179A314B0C0C01C0BF803

For test in question, the server instance n2c1m4 was killed to test for FAILURE notification. Thus, the log event does not capture an event that should be viewed as a failure. The log message needs to be improved to specifically state what server instance the send message was going to when it failed. Future fix will make sure that sendmessage to a FAILING instance are only reported once in server log and reported with actual server instance name.

Environment

Operating System: All Platform: All

Affected Versions

[current]

glassfishrobot commented 6 years ago
glassfishrobot commented 16 years ago

@glassfishrobot Commented Reported by @jfialli

glassfishrobot commented 16 years ago

@glassfishrobot Commented @jfialli said: Long term solution for this issue is described in https://shoal.dev.java.net/issues/show_bug.cgi?id=72

Fix checked into shoal for sailfin 0.5 branch.

glassfishrobot commented 7 years ago

@glassfishrobot Commented This issue was imported from java.net JIRA SHOAL-73

glassfishrobot commented 14 years ago

@glassfishrobot Commented Marked as fixed on Wednesday, June 23rd 2010, 4:11:06 am