add isLoggable around logging that is lower than warning - Githubissues

eclipse-ee4j / glassfish-shoal

Shoal

Other

5 stars 9 forks source link

add isLoggable around logging that is lower than warning #78

Closed glassfishrobot closed 13 years ago

glassfishrobot commented 15 years ago

Performance optimization:

logging messages that concatenate strings together as parameters waste processing time. All logging messages that concatenate strings together and logging level is less than WARNING need to follow this pattern.

if (logger.isLoggable(Level.XXX) )

{ log.XXX("..." + "...." + ...); }

where XXX is logging level less than WARNING.

Environment

Operating System: All Platform: All

Affected Versions

[current]

glassfishrobot commented 6 years ago

Issue Imported From: https://github.com/javaee/shoal/issues/78
Original Issue Raised By:@glassfishrobot
Original Issue Assigned To: @jfialli
Original Issue Closed By:@glassfishrobot

glassfishrobot commented 15 years ago

@glassfishrobot Commented Reported by @jfialli

glassfishrobot commented 15 years ago

@glassfishrobot Commented @jfialli said: take ownership of task

glassfishrobot commented 15 years ago

@glassfishrobot Commented @jfialli said: Accept task. Given that it is not high priority, it will be placed in queue. Should be completed before Sailfin 1.5 ships.

glassfishrobot commented 15 years ago

@glassfishrobot Commented @jfialli said: Partially fixed for distributed state cache logging messages.

glassfishrobot commented 13 years ago

@glassfishrobot Commented @jfialli said: fixes checked in

glassfishrobot commented 7 years ago

@glassfishrobot Commented This issue was imported from java.net JIRA SHOAL-78

glassfishrobot commented 13 years ago

@glassfishrobot Commented Marked as fixed on Friday, November 12th 2010, 4:43:34 am