search

eclipse-ee4j / glassfish-woodstock

GlassFish Woodstock UI components
Other
3 stars 15 forks source link

Remove Apache Commons FileUpload shading #1407

Open jGauravGupta opened 4 years ago

jGauravGupta commented 4 years ago

Apache Commons FileUpload currently depends on javax.servlet v2.4, I have created following PR for JakartaEE namespace transition: https://github.com/apache/commons-fileupload/pull/25 Which is breaking change for end-users so requested by maintainers to initially distribute dependency with Jakarta classifier: https://github.com/apache/commons-fileupload/pull/26

So, I created the PR(https://github.com/eclipse-ee4j/glassfish-woodstock/pull/1406) to shade Apache Commons FileUpload dependency in GlassFish Woodstock. Apache Commons FileUpload shading should be reverted, once commons-fileupload with JakartaEE namespace available on maven central.

jGauravGupta commented 4 years ago

Jakarta Servlet support available via https://github.com/apache/commons-fileupload/commit/cd031805d2618b0c1dd9c90265ebea1a1ce85387