Use dependencyManagement

[glassfishrobot]

A lot of pom.xmls still specify versions instead of using dependencyManagement. Take a look at the output produced by the following command: find . -name pom.xml | xargs grep version | grep -v ^./pom.xml | grep -v project.*.version | grep -v 3.0-SNAPSHOT | grep -v target | grep /version | grep -v publish | grep -v tests

./ejb/ejb-container/pom.xml: $

{pom.parent.version} ./ejb/ejb-container/pom.xml:

${glassfish-corba.version}

./ejb/ejb-timer-service-app/pom.xml: 2.0.2 ./orb/orb-connector/pom.xml:

${glassfish-corba.version}

./orb/orb-connector/pom.xml: ${pom.parent.version}

./orb/orb-iiop/pom.xml: $

{pom.parent.version} ./orb/orb-iiop/pom.xml: ${glassfish-corba.version} ./orb/orb-iiop/pom.xml: ${glassfish-corba.version} ./orb/orb-iiop/pom.xml: ${glassfish-corba.version} ./orb/orb-iiop/pom.xml: ${glassfish-corba.version} ./orb/orb-iiop/pom.xml: ${glassfish-corba.version} ./web/jstl-connector/pom.xml: ${jstl-impl.version} ./web/web-embed/impl/pom.xml: 1.1 ./web/jsf-connector/pom.xml: ${jsf-impl.version} ./core/branding/pom.xml: 4.3.1 ./core/kernel/pom.xml: 1.1 ./core/kernel/pom.xml: 1.0-2 ./core/bootstrap/pom.xml: 1.1 ./jdbc/jdbc-ra/jdbc-core/pom.xml: 4.3.1 ./jdbc/jdbc-ra/pom.xml: 1.8 ./jdbc/pom.xml: 1.8 ./persistence/cmp/support-sqlstore/pom.xml:

${antlr.version}

./persistence/cmp/support-ejb/pom.xml:

${antlr.version}

./appclient/client/acc/pom.xml: 2.2 ./appclient/client/acc/pom.xml: 2.4 ./appclient/client/acc/pom.xml: 2.1 ./appclient/client/acc/pom.xml: ${acc.corba-version} ./appclient/client/acc-config/pom.xml: 2.2 ./appclient/server/core/pom.xml: 1.6 ./appclient/server/core/pom.xml: 1.6 ./appclient/server/core/pom.xml: ${hk2.version} ./maven-plugin/src/test/start/pom.xml: 1.8 ./maven-plugin/src/test/start/pom.xml: 2.0 ./maven-plugin/src/test/start/pom.xml: 2.0 ./maven-plugin/src/test/deploy/pom.xml: 1.8 ./maven-plugin/src/test/deploy/pom.xml: 2.0 ./maven-plugin/src/test/deploy/pom.xml: 2.0 ./maven-plugin/src/test/pom.xml: 1.8 ./maven-plugin/src/test/pom.xml: 2.0 ./maven-plugin/src/test/pom.xml: 2.0 ./maven-plugin/src/test/pom.xml: 3.8.1 ./maven-plugin/pom.xml: 1.8 ./maven-plugin/pom.xml: 2.0 ./maven-plugin/pom.xml: 2.0 ./admin/rest/pom.xml: 1.1 ./admin/addon/pom.xml: 1.1-SNAPSHOT ./admin/addon/pom.xml: 1.1-SNAPSHOT ./admin/addon/pom.xml: 1.1-SNAPSHOT ./admin/addon/pom.xml: 4.3.1 ./admin/runtime/rtapt/apt/pom.xml: 1.1-SNAPSHOT ./admin/runtime/rtapt/apt/pom.xml: 1.1-SNAPSHOT ./admin/runtime/rtapt/apt/pom.xml: 1.4.2 ./admin/runtime/rtapt/annotations/pom.xml: 1.1-SNAPSHOT ./admin/runtime/rtapt/pom.xml: 1 ./admin/runtime/rtapt/pom.xml: 1.1-SNAPSHOT ./admin/config-api/pom.xml: 1.0 ./build/maven-glassfishbuild-extension/pom.xml: 2.0.7 ./build/glassfishbuild-repo-setup/pom.xml: ${mq.version} ./build/glassfishbuild-repo-setup/pom.xml: ${javadb.version} ./build/glassfishbuild-repo-setup/pom.xml: ${javadb.version} ./build/glassfishbuild-repo-setup/pom.xml: ${javadb.version} ./build/glassfishbuild-repo-setup/pom.xml: ${javadb.version} ./build/glassfishbuild-repo-setup/pom.xml: ${javadb.version} ./build/glassfishbuild-repo-setup/pom.xml: ${javadb.version} ./build/maven-glassfishbuild-plugin/pom.xml: 1.8 ./build/maven-glassfishbuild-plugin/pom.xml: 1.3.1 ./build/maven-glassfishbuild-plugin/pom.xml: 2.0 ./build/maven-glassfishbuild-plugin/pom.xml: 2.0.7 ./build/maven-glassfishbuild-plugin/pom.xml:

1.0-beta-3

./build/maven-glassfishbuild-plugin/pom.xml:

1.0-beta-3

./build/maven-glassfishbuild-plugin/pom.xml: 2.0 ./build/maven-glassfishbuild-plugin/pom.xml: 2.0 ./build/maven-glassfishbuild-plugin/pom.xml: 1.7.0 ./build/maven-glassfishbuild-plugin/pom.xml: 1.1 ./build/pom.xml: 1.0-beta-2 ./packager/mq/pom.xml: ${mq.version} ./packager/external/ant/pom.xml: 1.7.0 ./packager/external/ant/pom.xml: 1.7.0 ./packager/external/jmsra/pom.xml: ${mq.version} ./packager/external/apache-commons/pom.xml:

${commons.beanutils.version}

./packager/external/apache-commons/pom.xml:

${commons.collections.version}

./packager/external/apache-commons/pom.xml:

${commons.digester.version}

./packager/external/apache-commons/pom.xml:

${commons.modeler.version}

./packager/external/jmxremote_optional/pom.xml:

1.0_01-ea

./packager/external/javadb/pom.xml: ${javadb.version} ./packager/external/ldapbp/pom.xml: 1.0 ./packager/external/sysnet-registration/pom.xml: 1.0.2 ./packager/external/asm-all/pom.xml: ${asm.version} ./packager/external/commons-codec/pom.xml:

20041127.091804

./packager/external/jaxr_ra/pom.xml: ${jaxr.version} ./packager/glassfish-web-incorporation/pom.xml:

0.2

./packager/glassfish-generic-ra/pom.xml: 2.0-20081121 ./packager/glassfish-hk2/pom.xml: ${hk2.version} ./packager/glassfish-gui/pom.xml:

${dataprovider.version}

./packager/glassfish-gui/pom.xml:

${jsftemplating.version}

./packager/glassfish-jsf/pom.xml: ${jsf-api.version} ./packager/glassfish-jsf/pom.xml: ${jsf-impl.version} ./packager/glassfish-jdbc-gui/pom.xml: 0.2 ./packager/glassfish-full-incorporation/pom.xml:

0.2

./packager/glassfish-common-tmp/pom.xml: 2.0.02 ./packager/glassfish-corba-omgapi/pom.xml:

${glassfish-corba.version}

./packager/jersey/pom.xml: ${jersey.version} ./packager/glassfish-nucleus/pom.xml: 3.0-Prelude ./packager/glassfish-nucleus/pom.xml: 3.0.0-b008 ./packager/glassfish-corba/pom.xml:

${glassfish-corba.version}

./packager/glassfish-corba/pom.xml:

${glassfish-corba.version}

./packager/glassfish-corba/pom.xml:

${glassfish-corba.version}

./packager/glassfish-web-gui/pom.xml: 0.2 ./packager/glassfish-scripting/pom.xml:

${jruby-scripting.version}

./packager/glassfish-codegen/pom.xml:

${glassfish-corba.version}

./packager/glassfish-codegen/pom.xml:

${glassfish-corba.version}

./packager/glassfish-codegen/pom.xml:

${glassfish-corba.version}

./deployment/dol/pom.xml: ${hk2.version} ./deployment/dol/pom.xml:

${javax-persistence-api.version}

./deployment/dol/pom.xml: ${pom.parent.version}

./javaee-api/javax.servlet.jsp/pom.xml:

$ {jsp-api.version}

./javaee-api/javax.servlet.jsp/pom.xml:

$ {el-api.version}

./javaee-api/javax.mail/pom.xml: $

{mail.version}

./javaee-api/javax.javaee/compact/pom.xml: 1.1.1 ./javaee-api/javax.javaee/compact/pom.xml: 1.6 ./javaee-api/javax.javaee/compact/pom.xml: 1.6 ./javaee-api/javax.javaee/compact/pom.xml: 1.6.0 ./javaee-api/javax.javaee/pom.xml: RELEASE ./javaee-api/javax.javaee/pom.xml: RELEASE ./javaee-api/javax.javaee/pom.xml: 1.1 ./javaee-api/javax.javaee/pom.xml:

$ {javax-persistence-api.version}

./javaee-api/javax.javaee/pom.xml:

3.0-JBoss-4.0.0.Beta1-b01

./javaee-api/javax.javaee/pom.xml: ${webbeans.version} ./javaee-api/javax.javaee/pom.xml: 4.3 ./javaee-api/javax.javaee/pom.xml:

${jstl-impl.version}

./javaee-api/javax.xml.bind/pom.xml:

${jaxb-api.version}

./javaee-api/javax.xml.soap/pom.xml:

${saaj-api.version}

./javaee-api/javax.xml.stream/pom.xml:

${stax-api.version}

./javaee-api/javax.xml.rpc/pom.xml:

${jaxrpc-api.version}

./javaee-api/javax.servlet.jsp.jstl/pom.xml:

${jstl-api.version}

./javaee-api/javax.xml.ws/pom.xml:

${jaxws-api.version}

./javaee-api/pom.xml: 4.3.1 ./javaee-api/javax.jms/pom.xml: ${jms-api.version} ./javaee-api/javax.jws/pom.xml: ${jsr181-api.version} ./webservices/jsr109-impl/pom.xml:

${webservices.version>}

./webservices/jsr109-impl/pom.xml:

${jaxb.version}

./synchronization/pom.xml: ${hk2.plugin.version} ./synchronization/pom.xml: 4.3.1 ./common/glassfish-api/pom.xml: ${hk2.version} ./common/glassfish-api/pom.xml: 4.3.1 ./common/amx-ext-impl/pom.xml: 3.0.0-b004 ./common/glassfish-naming/pom.xml: 1.0 ./common/container-common/pom.xml: 4.3.1 ./extras/grizzly-container/pom.xml: ${hk2.version} ./extras/jmxcmd/pom.xml: 1.0-SNAPSHOT ./extras/jmxcmd/pom.xml: 0.9.9 ./extras/jmxcmd/pom.xml: 4.5 ./extras/jmxcmd/pom.xml: 1.0.1_04 ./extras/jmxcmd/pom.xml: 1.0_01-ea ./extras/osgi-container/pom.xml: ${hk2.version} ./verifier/verifier-impl/pom.xml: 2.0.02 ./osgi-platforms/felix/pom.xml:

2.0.0

./osgi-platforms/felix/pom.xml:

1.4.0

./osgi-platforms/felix/pom.xml:

1.4.0

./osgi-platforms/felix/pom.xml:

1.0.4

./osgi-platforms/felix/pom.xml:

1.2.0

./osgi-platforms/felix/pom.xml:

1.2.4

./osgi-platforms/felix/pom.xml:

1.0.8

./osgi-platforms/felix/pom.xml: 1.0.3 ./security/core/pom.xml: 1.0 ./security/core/pom.xml: 1.0 ./security/ejb.security/pom.xml:

${glassfish-corba.version}

./security/ejb.security/pom.xml:

${glassfish-corba.version}

./security/ejb.security/pom.xml:

${glassfish-corba.version}

./flashlight/framework/pom.xml: 1.6.0 ./flashlight/framework/pom.xml: 1.6.0 ./flashlight/btrace/pom.xml: 1.0.3 ./flashlight/btrace/pom.xml: 1.0.3 ./flashlight/client/pom.xml: 1.6.0 ./ant-tasks/pom.xml: 1.7.0 ./transaction/jta/pom.xml:

${javax-persistence-api.version}

./transaction/jts/pom.xml: $

{glassfish-corba.version} ./transaction/jts/pom.xml: ${glassfish-corba.version}

./transaction/internal-api/pom.xml:

$ {javax-persistence-api.version}

./admingui/war/pom.xml: 2.0.2 ./admingui/war/pom.xml: $

{scales.version}

./admingui/war/pom.xml: 3.0-b01 ./admingui/war/pom.xml: 1.1.1 ./admingui/core/pom.xml: 1.0 ./admingui/core/pom.xml: 0.4.1 ./admingui/core/pom.xml: 1.5.0 ./admingui/jsftemplating/pom.xml: $

{jsftemplating.version} ./admingui/jsftemplating/pom.xml:

${jsftemplating.version}

./admingui/console-plugin-archetype/src/main/resources/archetype-resources/pom.xml:

$ {hk2.plugin.version}

./admingui/console-plugin-archetype/pom.xml: 1.0-beta-2 ./admingui/console-plugin-archetype/pom.xml: 2.0-alpha-3 ./admingui/console-plugin-archetype/pom.xml: 2.0-alpha-3 ./admingui/plugin-service/pom.xml: <!-10.0.0-rev6-> ./admingui/plugin-service/pom.xml: ./admingui/common/pom.xml:

${jsftemplating.version}

./admingui/common/pom.xml: ${jsftemplating.version} ./admingui/common/pom.xml: ${jsftemplating.version} ./admingui/common/pom.xml: ${jsf-api.version} ./admingui/dataprovider/pom.xml: 4.2 ./admingui/dataprovider/pom.xml: 1.0 ./admingui/community-theme/pom.xml:

${hk2.plugin.version}

./admingui/jms-plugin/pom.xml: 4.3 ./admingui/pom.xml:

$ {jsftemplating.version}

./admingui/pom.xml: ${hk2.version} ./admingui/pom.xml: ${jsftemplating.version}

./admingui/pom.xml: $

{jsftemplating.version}

./admingui/pom.xml: $

{jsf-api.version}

./admingui/pom.xml: $

{dataprovider.version}

./distributions/web/pom.xml: 2.4.2 ./distributions/appclient/pom.xml: 2.2-beta-3 ./distributions/nucleus/pom.xml: 2.4.2 ./distributions/nucleus/pom.xml: $

{hk2.version} ./installer/pom.xml: 1.6 ./installer/pom.xml: 0.9.4.6 ./installer/pom.xml: 0.9.4.2 ./registration/glassfish-registration/pom.xml:

${hk2.version}

Environment

Operating System: All Platform: All

Affected Versions

[V3]

[glassfishrobot]

• Issue Imported From: https://github.com/javaee/glassfish/issues/10456
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @yaminikb
• Original Issue Closed By:@glassfishrobot

[glassfishrobot]

@glassfishrobot Commented janey said: confirmed

[glassfishrobot]

@glassfishrobot Commented janey said: working on this...

[glassfishrobot]

@glassfishrobot Commented janey said: Added the following to dependencyManagement:

• com.sun.tools.btrace
• btrace-agent
• $

{btrace.version}

• com.sun.tools.btrace
• btrace-boot
• ${btrace.version}

• com.sun.corba
• glassfish-corba-orbgeneric
• $

{glassfish-corba.version}

• com.sun.corba
• glassfish-corba-omgapi
• ${glassfish-corba.version}

• org.kohsuke.metainf-services
• metainf-services
• 1.1
• javax.xml.stream
• stax-api
• $

{stax-api.version}

• com.sun.xml.stream
• sjsxp
• 1.0
• junit
• junit
• 4.3.1

[glassfishrobot]

@glassfishrobot Commented janey said: Add more dependencies in dependencyManagement in v3/pom.xml:

• com.sun.jsftemplating
• jsftemplating
• $

{jsftemplating.version}

• com.sun.jsftemplating
• jsftemplating-dt
• ${jsftemplating.version}

• com.sun.woodstock.dependlibs
• json
• 1.0
• com.sun.woodstock.dependlibs
• dojo-ajax
• 0.4.1
• com.sun.woodstock.dependlibs
• prototype
• 1.5.0
• com.sun.woodstock.dependlibs
• dataprovider
• 1.0
• com.sun.messaging.mq
• imqjmx
• 4.3

and remove the version element in the submodule pom files.

svn revision 33918.

[glassfishrobot]

@glassfishrobot Commented janey said: Remove hard-coded version in admingui/dataprovider/pom.xml

Index: pom.xml

==== — pom.xml (revision 34372) +++ pom.xml (working copy) @@ -127,7 +127,6 @@

1.0-rev-1 2.1.3 1.0-2 * 4.2 2.0.2 1.3.1 3.0.0-b038 Index: packager/glassfish-gui/pom.xml =============================================================== ==== * * packager/glassfish-gui/pom.xml (revision 34372) +++ packager/glassfish-gui/pom.xml (working copy) @@ -79,7 +79,7 @@ org.glassfish.admingui dataprovider * $ {dataprovider.version} + ${project.version} com.sun.jsftemplating Index: admingui/dataprovider/pom.xml =============================================================== ==== — admingui/dataprovider/pom.xml (revision 34372) +++ admingui/dataprovider/pom.xml (working copy) @@ -48,7 +48,6 @@ org.glassfish.admingui dataprovider DataProvider - 4.2 4.0.0 DataProvider Repackaged as OSGi bundle for GlassFish Index: admingui/core/pom.xml =============================================================== ==== — admingui/core/pom.xml (revision 34372) +++ admingui/core/pom.xml (working copy) @@ -206,5 +206,11 @@ ${project.version} provided + + org.glassfish.admingui + dataprovider + ${project.version} + provided + Index: admingui/pom.xml =============================================================== ==== — admingui/pom.xml (revision 34372) +++ admingui/pom.xml (working copy) @@ -146,20 +146,5 @@ ${project.version} provided - - org.glassfish.admingui - dataprovider - ${dataprovider.version} * provided * - * - * * 4.2 *

[glassfishrobot]

@glassfishrobot Commented janey said: Add more to dependencyManagement.

Index: pom.xml

==== — pom.xml (revision 34382) +++ pom.xml (working copy) @@ -159,6 +159,7 @@

1.0-b01-ea 3.0-b07 3.0-b70 + 3.1 @@ -910,6 +911,12 @@ 1.2.0 + org.apache.felix + org.apache.felix.main + 1.0.3 + + + org.osgi osgi_R4_core 1.0 @@ -1125,8 +1132,19 @@ com.sun.corba glassfish-corba-asm $ {glassfish-corba.version} - + + com.sun.corba + glassfish-corba-csiv2-idl + ${glassfish-corba.version} + + + com.sun.corba + glassfish-corba-newtimer + $ {glassfish-corba.version} + + + org.kohsuke.metainf-services metainf-services 1.1 @@ -1262,6 +1280,11 @@ $ {jstl-api.version} + org.glassfish.web + jstl-impl + $ {jstl-impl.version} + + javax.xml jaxrpc-api $ {jaxrpc-api.version} @@ -1272,6 +1295,32 @@ $ {saaj-api.version} + + org.glassfish + genericra + 2.0-20081121 + + + com.sun.scn + sysnet-registration + 1.0.2 + + + com.sun + ldapbp + 1.0 + + + commons-codec + commons-codec + 20041127.091804 + + + asm + asm-commons + $ {asm.version} + +

[glassfishrobot]

@glassfishrobot Commented janey said: There are other artifacts that have versions specified in the submodule pom.xml files since they are either plugin and extension artifacts or dependencies specified in the configuration element of a plugin. Also I found out I can't use dependencyManagement when the dependency is either a pom, rar or zip type.

Example: add the mq-distribution artifact in dependencyManagement in v3/pom.xml and remove version element for mq-distribution artifact in v3/packager/mq/pom.xml and the build will fail.

I have taken care of most of the dependencies in v3 workspace but don't think I can take care of all the dependencies because of the above issues mentioned.

I will leave this bug open but mark as v3_exclude and revisit this after v3.

[glassfishrobot]

@glassfishrobot Commented kumara said: Setting target release for unresolved issues submitted on v3 release to the next release. Not changing issues submitted on v2.x release because they might not apply to v3.next release.

[glassfishrobot]

@glassfishrobot Commented janey said: I'm closing this bug since majority of the dependencies in v3 workspace are adding to v3/pom.xml's dependencyManagement (other than the exceptions I mentioned in the earlier comment).

[glassfishrobot]

@glassfishrobot Commented Was assigned to janey

[glassfishrobot]

@glassfishrobot Commented This issue was imported from java.net JIRA GLASSFISH-10456

[glassfishrobot]

@glassfishrobot Commented Reported by ss141213

[glassfishrobot]

@glassfishrobot Commented Marked as fixed on Wednesday, October 6th 2010, 10:09:59 pm