OLH integratoin errors

[glassfishrobot]

Build: http://download.java.net/glassfish/v3/nightly/glassfish-v3-b71-10_30_2009.zip

I did a quick check on the OLH. For the following pages, OLH popup window shows "HTTP Status 404":

1) Resources [Everything under Resources node seems to be broken] 2) Resources > JDBC 3) Resources > JDBC > JDBC Resources 4) Resources > JDBC > Connection Pools 5) Resources > Connectors 6) Resources > Resource Adapter Configs 7) Resources > JMS Resources 8) Resources > JavaMail Sessions 9) Resources > JNDI

10) Configuration > Web Container 11) Configuration > EJB Container 12) Configuration > Ruby Container 13) Configuration > Java Message Service 14) Configuration > Transaction Service 15) Configuration > Http Service 16) Configuration > Virtual Servers 17) Configuration > Network Config 18) Configuration > Thread Pools 19) Configuration > ORB

20) Enterprise Server > Monitor (all 3 tabs) 21) Applications > Deploy

Environment

Operating System: All Platform: All

Affected Versions

[V3]

[glassfishrobot]

• Issue Imported From: https://github.com/javaee/glassfish/issues/10724
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @yaminikb
• Original Issue Closed By:@glassfishrobot

[glassfishrobot]

@glassfishrobot Commented ai109478 said: Created an attachment (id=3706) Example of http 404 error

[glassfishrobot]

@glassfishrobot Commented chaase3 said:

• • • Issue 10725 has been marked as a duplicate of this issue. ***

[glassfishrobot]

@glassfishrobot Commented chaase3 said: As of the 11/1 nightly build, the pages that the Help button causes an error 404 for are actually present in the help and can be reached by using the TOC or the index in the left pane of the help window. The problem is with the navigation.

[glassfishrobot]

@glassfishrobot Commented @edburns said: Thanks Anissa,

I'm evaluating this now.

[glassfishrobot]

@glassfishrobot Commented chaase3 said: Error 404s also appear in the 11/1 b71 build for the 3 sub-tabs under Enterprise Server->Monitor. These are caused by errors in our Helplinks.properties file that have now been fixed.

[glassfishrobot]

@glassfishrobot Commented ai109478 said:

• • • Issue 9924 has been marked as a duplicate of this issue. ***

[glassfishrobot]

@glassfishrobot Commented ai109478 said: Issue 9924 "MDB Default Pool Settings"

[glassfishrobot]

@glassfishrobot Commented @edburns said: Thanks, I'll fix these.

[glassfishrobot]

@glassfishrobot Commented anilam said:

• • • Issue 10767 has been marked as a duplicate of this issue. ***

[glassfishrobot]

@glassfishrobot Commented ai109478 said: -> Jason

[glassfishrobot]

@glassfishrobot Commented jdlee said: I've committed the fix for this. The JS was hard-coding the path prefix for the files, which breaks for all modules but common. I added a handler to determine the module ID, and some JS to then calculate the path prefix based on that ID and the locale. I've tested the pages listed below and, I think, just about every link from the tree, and almost all the help pages work as expected. The instances that failed appear to be addressed in 10814. I'm adding a blocking dependency on that issue and will leave this open until that one is closed the 404s are confirmed as resolved.

[glassfishrobot]

@glassfishrobot Commented chaase3 said: Most of these are now fixed. I'm using Hudson build 3273 (between 11/7 and 11/8 nightlies).

Resources pages no longer draw Error 404, with one exception which I will describe in another entry. Basically, items 2 through 7 and items 10 through 19 in the original report are fixed.

Items 8 and 9 (Javamail, JNDI) will be fixed at the next help integration (issue 10814).

[glassfishrobot]

@glassfishrobot Commented chaase3 said: Using Hudson build 3273, I found one error 404 that requires a change to the docs and the helplinks. I put the help topic for the Resources node in the JDBC help set because that seemed a logical place for it. However, I find the resources node page – if this is it – in admingui/common/src/main/resources/resourceNode/resources.jsf, with the helpkey defined as follows:

<sun:hidden id="helpKey" value="$resource

{help.resources}

" />

This indicates that the file common/src/main/resources/org/glassfish/common/admingui/Helplinks.properties has to have a key named "resources" that points to the topic I wrote. (It doesn't, at present.) Therefore, I need to move the help topic out of the JDBC help set and into the common help set, and I need to define this key and its value in the Helplinks.properties file. I'll make these changes.

[glassfishrobot]

@glassfishrobot Commented chaase3 said: Items 20 and 21 in the initial report are still valid, though the keys seem to be correctly defined. In addition, the Registration page and the Edit Application page draw an Error 404; again, the keys seem to be correctly defined. I don't know the cause of these problems. These are the way the keys are defined so perhaps the problem is with the pages.

GlassFish News (GF 11/7 build) common/src/main/resources/org/glassfish/common/admingui/Helplinks.properties support=ref-supportpage.html

Registration (Hudson build 3273) common/src/main/resources/org/glassfish/common/admingui/Helplinks.properties registration=ref-registrationpage.html

Enterprise Server: Monitor (all 3) common/src/main/resources/org/glassfish/common/admingui/Helplinks.properties monitorApps=ref-appmonitoringdata.html monitorRuntime=ref-servermonitoringdata.html monitorResources=ref-resourcemonitoringdata.html

Deploy Applications or Modules core/src/main/resources/org/glassfish/admingui/core/Helplinks.properties uploadDev=ref-uploaddev.html

Edit Application core/src/main/resources/org/glassfish/admingui/core/Helplinks.properties applicationEdit=ref-appedit.html

I also found that the New Provider Configuration page brings up the Edit Provider Configuration help, though the keys are correctly defined:

msgProviderNew=ref-messagesecurityproviderconfignew.html msgProviderEdit=ref-messagesecurityproviderconfigedit.html

The providerNew.jsf page defined the key incorrectly. I have taken the liberty of changing it.

There's one major problem I can't fix. The help for the Update Tool is part of the common help and has been, all along. However, the keys for it seem to be defined in a separate module:

updatecenter/src/main/resources/org/glassfish/updatecenter/admingui/Helplinks.properties

We were never told to provide a separate help set for the update center help, and it is way too late to create a new one at this stage. Therefore, the help keys for the update center have to be defined in the common help or have to refer to the common help set, somehow.

[glassfishrobot]

@glassfishrobot Commented jdlee said: Kim, I've committed some changes to address the upload page (improperly defined help key. It was a string literal and not an EL expression, for the record) as well as fixes for the monitoring tabs (the server was navigating to incorrect, but oddly still functional, urls, which led to incorrect plugin calculation). I think this leaves only the update center issue, on which I'll have to think some more.

[glassfishrobot]

@glassfishrobot Commented chaase3 said: Thanks, Jason. Hope you can solve the update center help issue. If we'd only known before that it was a whole separate module!

I created new topics for the View JMS Physical Destination Statistics page, which I only just noticed (how long has it been there?). I updated the helplinks file to point to the new reference topic, which will show up when we next integrate the help.

[glassfishrobot]

@glassfishrobot Commented jdlee said: I just committed some JS fixes to work around the update center issue. Ideally, after HCF, etc., we'd move the UC help to its own module and avoid the hack, but this works well enough for now. This should cover all the known issues. Once you verify, please close this issue out (or let me know so I can).

[glassfishrobot]

@glassfishrobot Commented jdlee said: All known issues have been addressed. Any pages that may have made it past testing will need to be addressed as separate issues.

[glassfishrobot]

@glassfishrobot Commented chaase3 said: Jason, clicking Help from the GlassFish News page still gives me an Error 404,in the glassfish-v3-b72-11_09_2009.zip build. Is this expected?

[glassfishrobot]

@glassfishrobot Commented jdlee said: I could have sworn I tested that page explicitly, but I'm getting the same result. I'll commit a fix shortly.

[glassfishrobot]

@glassfishrobot Commented chaase3 said: At least one more Error 404 has cropped up. Reopening to fix. (Connector Service page)

[glassfishrobot]

@glassfishrobot Commented anilam said: Kim, Is the fix in v3-docs ? Or are you expecting some change in GUI ? thanks

[glassfishrobot]

@glassfishrobot Commented chaase3 said: I committed the v3/admingui/jca/src/main/resources/org/glassfish/jca/admingui/Helplinks.properties file with a one-line change:

##############################

1. Connectro Service under configuration ############################## -connectorService=ref-connectionService.html \ No newline at end of file +connectorService=ref-connectionservice.html

You'd given the help topic a capital letter, which it does not have.

[glassfishrobot]

@glassfishrobot Commented chaase3 said: misspelled my own user id

[glassfishrobot]

@glassfishrobot Commented anilam said: Since Kim has fixed the helplink for "connector service", which is the reason she re-open this bug, I am closing this as resolved.

If there is any other page that doesn't have the help file showing up, please file a separate bug for that specific page. We will decide if it is critical enough to be fixed for v3.

thanks

[glassfishrobot]

@glassfishrobot Commented File: http404.png Attached By: ai109478

[glassfishrobot]

@glassfishrobot Commented Issue-Links: depends on GLASSFISH-10814

[glassfishrobot]

@glassfishrobot Commented Was assigned to chaase3

[glassfishrobot]

@glassfishrobot Commented This issue was imported from java.net JIRA GLASSFISH-10724

[glassfishrobot]

@glassfishrobot Commented Reported by ai109478