fix message IDs, typos - Githubissues

glassfishrobot commented 15 years ago

Sekhar wrote a tool to pick up messages with no ID.

http://wiki.glassfish.java.net/attach/GlassFishV3LoggingServiceability/msgidlist .html http://wiki.glassfish.java.net/attach/GlassFishV3LoggingServiceability/msgidlist -gray.html

Analysis of the results has uncovered issues such as the following:

some msg IDs don't follow the format rules (for instance, 'JTS5027.diag1.check.1')
some msgs are broken up into multiple lines without a '\' at the end
some msgs have typos

I've prepared patches to fix these issues in all LogStrings, LocalStrings and Bundle (cmp) message files. These patches do not address the original problem of WARNING/ERROR msgs not having IDs.

Environment

Operating System: All Platform: All

Affected Versions

[V3]

glassfishrobot commented 6 years ago

Issue Imported From: https://github.com/javaee/glassfish/issues/10884
Original Issue Raised By:@glassfishrobot
Original Issue Assigned To: @yaminikb
Original Issue Closed By:@glassfishrobot

glassfishrobot commented 15 years ago

@glassfishrobot Commented dkoper said: Created an attachment (id=3814) patch for typos in cmp bundle.properties files

glassfishrobot commented 15 years ago

@glassfishrobot Commented dkoper said: Created an attachment (id=3815) patch for typos in LocalStrings.properties files

glassfishrobot commented 15 years ago

@glassfishrobot Commented dkoper said: Created an attachment (id=3816) patches for msg ID problems and typos in LogStrings.properties files

glassfishrobot commented 15 years ago

@glassfishrobot Commented @h2002044 said: Following changes w.r.t connectors, jdbc look fine.

msg-local-typos.patch :

jdbc/jdbc-ra/jdbc-core/src/main/java/com/sun/gjc/common/LocalStrings.properties jdbc/admin/src/main/java/org/glassfish/jdbc/admin/cli/LocalStrings.properties connectors/admin/src/main/java/org/glassfish/connectors/admin/cli/LocalStrings.properties

msg-ids-typos.patch

jdbc/jdbc-ra/jdbc-core/src/main/java/com/sun/gjc/common/LocalStrings.properties jdbc/jdbc-ra/jdbc-core/src/main/resources/com/sun/gjc/spi/LogStrings.properties common/container-common/src/main/resources/org/glassfish/javaee/services/LogStrings.properties connectors/work-management/src/main/resources/com/sun/enterprise/connectors/work/LogStrings.properties connectors/connectors-runtime/src/main/resources/com/sun/logging/enterprise/resource/resourceadapter/LogStrings.properties connectors/connectors-internal-api/src/main/resources/com/sun/appserv/connectors/internal/api/LogStrings.properties

glassfishrobot commented 15 years ago

@glassfishrobot Commented dochez said: dies has patches.

glassfishrobot commented 15 years ago

@glassfishrobot Commented dkoper said: Fixed for all except ejb, security, verifier, admin/launcher.

Sending appclient\client\acc\src\main\resources\org\glassfish\appclient\client\acc\LogSt rings.properties Sending appclient\server\core\src\main\resources\org\glassfish\appclient\server\core\Log Strings.properties Sending appclient\server\core\src\main\resources\org\glassfish\appclient\server\core\jws \servedcontent\LocalStrings.pr operties Sending common\common- util\src\main\java\com\sun\logging\enterprise\system\LogStrings.properties Sending common\common- util\src\main\java\com\sun\logging\enterprise\system\activation\LogStrings.prope rties Sending common\common- util\src\main\java\com\sun\logging\enterprise\system\container\ejb\LogStrings.pr operties Sending common\common- util\src\main\java\com\sun\logging\enterprise\system\container\ejb\mdb\LogString s.properties Sending common\common- util\src\main\java\com\sun\logging\enterprise\system\core\LogStrings.properties Sending common\common- util\src\main\java\com\sun\logging\enterprise\system\core\classloading\LogString s.properties Sending common\common- util\src\main\java\com\sun\logging\enterprise\system\core\naming\LogStrings.prop erties Sending common\common- util\src\main\java\com\sun\logging\enterprise\system\core\selfmanagement\LogStri ngs.properties Sending common\common- util\src\main\java\com\sun\logging\enterprise\system\tools\admin\LogStrings.prop erties Sending common\common- util\src\main\java\com\sun\logging\enterprise\system\tools\launcher\LogStrings.p roperties Sending common\common- util\src\main\java\com\sun\logging\enterprise\system\util\LogStrings.properties Sending common\common- util\src\main\java\org\glassfish\admin\payload\LocalStrings.properties Sending common\container- common\src\main\resources\org\glassfish\javaee\services\LogStrings.properties Sending connectors\admin\src\main\java\org\glassfish\connectors\admin\cli\LocalStrings.p roperties Sending connectors\connectors-internal- api\src\main\resources\com\sun\appserv\connectors\internal\api\LogStrings.prope rties Sending connectors\connectors- runtime\src\main\resources\com\sun\logging\enterprise\resource\resourceadapter\L ogString s.properties Sending connectors\work- management\src\main\resources\com\sun\enterprise\connectors\work\LogStrings.prop erties Sending core\kernel\src\main\java\com\sun\enterprise\v3 \admin\LocalStrings.properties Sending core\kernel\src\main\java\com\sun\enterprise\v3 \admin\adapter\LocalStrings.properties Sending core\kernel\src\main\java\com\sun\enterprise\v3 \admin\commands\LocalStrings.properties Sending core\kernel\src\main\resources\com\sun\logging\enterprise\system\core\LogStrings .properties Sending deployment\autodeploy\src\main\java\org\glassfish\deployment\autodeploy\LocalStr ings.properties Sending deployment\client\src\main\java\org\glassfish\deployapi\config\LocalStrings.prop erties Sending deployment\client\src\main\java\org\glassfish\deployment\client\LocalStrings.pro perties Sending deployment\common\src\main\java\org\glassfish\deployment\common\LocalStrings.pro perties Sending deployment\common\src\main\resources\com\sun\logging\enterprise\system\tools\dep loyment\LogStrings.properties Sending deployment\common\src\main\resources\org\glassfish\deployment\common\LocalString s.properties Sending deployment\dol\src\main\java\com\sun\enterprise\deployment\LocalStrings.properti es Sending deployment\dol\src\main\java\com\sun\enterprise\deployment\annotation\handlers\L ocalStrings.properties Sending deployment\dol\src\main\java\com\sun\enterprise\deployment\util\LocalStrings.pro perties Sending extras\upgrade\upgrade- jar\src\main\resources\com\sun\enterprise\tools\upgrade\LocalStrings.properties Sending extras\upgrade\upgrade- jar\src\main\resources\com\sun\enterprise\tools\upgrade\common\LocalStrings.prop erties Sending extras\upgrade\upgrade- jar\src\main\resources\com\sun\enterprise\tools\upgrade\gui\LocalStrings.propert ies Sending flashlight\framework\src\main\java\org\glassfish\flashlight\impl\provider\LocalS trings.properties Sending jdbc\admin\src\main\java\org\glassfish\jdbc\admin\cli\LocalStrings.properties Sending jdbc\jdbc-ra\jdbc- core\src\main\java\com\sun\gjc\common\LocalStrings.properties Sending jdbc\jdbc-ra\jdbc- core\src\main\resources\com\sun\gjc\spi\LogStrings.properties Sending jms\admin\src\main\java\org\glassfish\jms\admin\cli\LocalStrings.properties Sending persistence\cmp\ejb- mapping\src\main\java\com\sun\jdo\api\persistence\mapping\ejb\Bundle.properties Sending persistence\cmp\support- ejb\src\main\java\com\sun\jdo\spi\persistence\support\ejb\cmp\Bundle.properties Sending persistence\cmp\support- ejb\src\main\java\com\sun\jdo\spi\persistence\support\ejb\ejbqlc\Bundle.properti es Sending persistence\cmp\support- sqlstore\src\main\java\com\sun\jdo\spi\persistence\support\sqlstore\Bundle.prope rties Sending transaction\jta\src\main\resources\com\sun\enterprise\transaction\LocalStrings.p roperties Sending transaction\jta\src\main\resources\com\sun\enterprise\transaction\LogStrings.pro perties Sending transaction\jts\src\main\resources\com\sun\jts\LogStrings.properties Sending web\gui-plugin- common\src\main\resources\org\glassfish\web\plugin\common\LocalStrings.propertie s Sending web\web- naming\src\main\resources\org\apache\naming\LocalStrings.properties Sending webservices\jsr109- impl\src\main\resources\org\glassfish\webservices\LogStrings.properties Transmitting file data ................................................... Committed revision 34151.

glassfishrobot commented 15 years ago

@glassfishrobot Commented dkoper said: Fix for security module.

Sending security\core\src\main\java\com\sun\enterprise\security\auth\digest\impl\LocalSt rings.properties Sending security\core\src\main\java\com\sun\enterprise\security\provider\LocalStrings.pr operties Sending security\core\src\main\resources\com\sun\logging\enterprise\system\core\security \LogStrings.properties Transmitting file data ... Committed revision 34172.

glassfishrobot commented 15 years ago

@glassfishrobot Commented dkoper said: Sending verifier\verifier- impl\src\main\resources\com\sun\enterprise\tools\verifier\LocalStrings.propertie s Transmitting file data . Committed revision 34180.

glassfishrobot commented 15 years ago

@glassfishrobot Commented dkoper said: Only ejb hasn't been committed yet.

Sending admin\launcher\src\main\java\com\sun\enterprise\admin\launcher\LocalStrings.prop erties Transmitting file data . Committed revision 34184.

glassfishrobot commented 15 years ago

@glassfishrobot Commented dkoper said: Last batch:

Sending ejb\ejb- container\src\main\resources\com\sun\logging\enterprise\system\container\ejb\Log Strings.properties Sending ejb\ejb- container\src\main\resources\com\sun\logging\enterprise\system\container\ejb\mdb \LogStrings.properties

Transmitting file data .. Committed revision 34235.

glassfishrobot commented 15 years ago

@glassfishrobot Commented File: msg-cmp-typos.patch Attached By: dkoper

glassfishrobot commented 15 years ago

@glassfishrobot Commented File: msg-ids-typos.patch Attached By: dkoper

glassfishrobot commented 15 years ago

@glassfishrobot Commented File: msg-local-typos.patch Attached By: dkoper

glassfishrobot commented 15 years ago

@glassfishrobot Commented Was assigned to dkoper

glassfishrobot commented 7 years ago

@glassfishrobot Commented This issue was imported from java.net JIRA GLASSFISH-10884

glassfishrobot commented 15 years ago

@glassfishrobot Commented Reported by dkoper

glassfishrobot commented 15 years ago

@glassfishrobot Commented Marked as fixed on Tuesday, November 10th 2009, 7:11:18 am

eclipse-ee4j / glassfish

fix message IDs, typos #10884

Environment

Affected Versions