eclipse-ee4j / glassfish

Eclipse GlassFish
https://eclipse-ee4j.github.io/glassfish/
383 stars 143 forks source link

asadmin get of instance system-property returning multiple values. #12917

Closed glassfishrobot closed 14 years ago

glassfishrobot commented 14 years ago

This is mainly observed when there are multiple instances configured on the same machine/node. domain.xml is attached.

ejp5360-vm1:/space/sony/builds/gfv3.1/glassfish # asadmin get instance101.system-property.* instance101.system-property.ASADMIN_LISTENER_PORT.name=ASADMIN_LISTENER_PORT instance101.system-property.ASADMIN_LISTENER_PORT.value=24848 instance101.system-property.HTTP_LISTENER_PORT.name=HTTP_LISTENER_PORT instance101.system-property.HTTP_LISTENER_PORT.value=28080 instance101.system-property.HTTP_SSL_LISTENER_PORT.name=HTTP_SSL_LISTENER_PORT instance101.system-property.HTTP_SSL_LISTENER_PORT.value=28181 instance101.system-property.IIOP_LISTENER_PORT.name=IIOP_LISTENER_PORT instance101.system-property.IIOP_LISTENER_PORT.value=23700 instance101.system-property.IIOP_SSL_LISTENER_PORT.name=IIOP_SSL_LISTENER_PORT instance101.system-property.IIOP_SSL_LISTENER_PORT.value=23820 instance101.system-property.IIOP_SSL_MUTUALAUTH_PORT.name=IIOP_SSL_MUTUALAUTH_PORT instance101.system-property.IIOP_SSL_MUTUALAUTH_PORT.value=23920 instance101.system-property.JMS_PROVIDER_PORT.name=JMS_PROVIDER_PORT instance101.system-property.JMS_PROVIDER_PORT.value=27676 instance101.system-property.JMX_SYSTEM_CONNECTOR_PORT.name=JMX_SYSTEM_CONNECTOR_PORT instance101.system-property.JMX_SYSTEM_CONNECTOR_PORT.value=28686

Command get executed successfully. ejp5360-vm1:/space/sony/builds/gfv3.1/glassfish # asadmin get instance102.system-property.* instance102.system-property.ASADMIN_LISTENER_PORT.name=ASADMIN_LISTENER_PORT instance102.system-property.ASADMIN_LISTENER_PORT.value=24848 instance102.system-property.HTTP_LISTENER_PORT.name=HTTP_LISTENER_PORT instance102.system-property.HTTP_LISTENER_PORT.value=28080 instance102.system-property.HTTP_SSL_LISTENER_PORT.name=HTTP_SSL_LISTENER_PORT instance102.system-property.HTTP_SSL_LISTENER_PORT.value=28181 instance102.system-property.IIOP_LISTENER_PORT.name=IIOP_LISTENER_PORT instance102.system-property.IIOP_LISTENER_PORT.value=23700 instance102.system-property.IIOP_SSL_LISTENER_PORT.name=IIOP_SSL_LISTENER_PORT instance102.system-property.IIOP_SSL_LISTENER_PORT.value=23820 instance102.system-property.IIOP_SSL_MUTUALAUTH_PORT.name=IIOP_SSL_MUTUALAUTH_PORT instance102.system-property.IIOP_SSL_MUTUALAUTH_PORT.value=23920 instance102.system-property.JMS_PROVIDER_PORT.name=JMS_PROVIDER_PORT instance102.system-property.JMS_PROVIDER_PORT.value=27676 instance102.system-property.JMX_SYSTEM_CONNECTOR_PORT.name=JMX_SYSTEM_CONNECTOR_PORT instance102.system-property.JMX_SYSTEM_CONNECTOR_PORT.value=28686

Command get executed successfully. ejp5360-vm1:/space/sony/builds/gfv3.1/glassfish # asadmin get instance103.system-property.* instance103.system-property.ASADMIN_LISTENER_PORT.name=ASADMIN_LISTENER_PORT instance103.system-property.ASADMIN_LISTENER_PORT.value=24849 instance103.system-property.ASADMIN_LISTENER_PORT.name=ASADMIN_LISTENER_PORT instance103.system-property.ASADMIN_LISTENER_PORT.value=24848 instance103.system-property.HTTP_LISTENER_PORT.name=HTTP_LISTENER_PORT instance103.system-property.HTTP_LISTENER_PORT.value=28080 instance103.system-property.HTTP_LISTENER_PORT.name=HTTP_LISTENER_PORT instance103.system-property.HTTP_LISTENER_PORT.value=28081 instance103.system-property.HTTP_SSL_LISTENER_PORT.name=HTTP_SSL_LISTENER_PORT instance103.system-property.HTTP_SSL_LISTENER_PORT.value=28182 instance103.system-property.HTTP_SSL_LISTENER_PORT.name=HTTP_SSL_LISTENER_PORT instance103.system-property.HTTP_SSL_LISTENER_PORT.value=28181 instance103.system-property.IIOP_LISTENER_PORT.name=IIOP_LISTENER_PORT instance103.system-property.IIOP_LISTENER_PORT.value=23701 instance103.system-property.IIOP_LISTENER_PORT.name=IIOP_LISTENER_PORT instance103.system-property.IIOP_LISTENER_PORT.value=23700 instance103.system-property.IIOP_SSL_LISTENER_PORT.name=IIOP_SSL_LISTENER_PORT instance103.system-property.IIOP_SSL_LISTENER_PORT.value=23821 instance103.system-property.IIOP_SSL_LISTENER_PORT.name=IIOP_SSL_LISTENER_PORT instance103.system-property.IIOP_SSL_LISTENER_PORT.value=23820 instance103.system-property.IIOP_SSL_MUTUALAUTH_PORT.name=IIOP_SSL_MUTUALAUTH_PORT instance103.system-property.IIOP_SSL_MUTUALAUTH_PORT.value=23920 instance103.system-property.IIOP_SSL_MUTUALAUTH_PORT.name=IIOP_SSL_MUTUALAUTH_PORT instance103.system-property.IIOP_SSL_MUTUALAUTH_PORT.value=23921 instance103.system-property.JMS_PROVIDER_PORT.name=JMS_PROVIDER_PORT instance103.system-property.JMS_PROVIDER_PORT.value=27677 instance103.system-property.JMS_PROVIDER_PORT.name=JMS_PROVIDER_PORT instance103.system-property.JMS_PROVIDER_PORT.value=27676 instance103.system-property.JMX_SYSTEM_CONNECTOR_PORT.name=JMX_SYSTEM_CONNECTOR_PORT instance103.system-property.JMX_SYSTEM_CONNECTOR_PORT.value=28687 instance103.system-property.JMX_SYSTEM_CONNECTOR_PORT.name=JMX_SYSTEM_CONNECTOR_PORT instance103.system-property.JMX_SYSTEM_CONNECTOR_PORT.value=28686

Command get executed successfully. ejp5360-vm1:/space/sony/builds/gfv3.1/glassfish #

Environment

Operating System: All Platform: All

Affected Versions

[3.1]

glassfishrobot commented 6 years ago
glassfishrobot commented 14 years ago

@glassfishrobot Commented sonymanuel said: Created an attachment (id=4652) domain.xml

glassfishrobot commented 14 years ago

@glassfishrobot Commented tmueller said: The reason for the multiple values for instance103 is that there are system-property values in the element as well as those in the for the server. Both are being printed. This is done intentionally by the code.

This behavior is consistent with the v3.0 behavior and it is not specific to instances (it happens with system-properties for the DAS too).

Not sure what the right behavior should be here. It would seem that maybe be the value from the config should be suppressed if it is overridden by the server.

The name of the instance is an alias for the values in the server and config elements. If you want just the server or config values, it is possible to request just those values, as in:

asadmin get servers.server.instance103.system-property.HTTP_LISTENER_PORT.value

or

asadmin get configs.config.default-config.system-property.HTTP_LISTENER_PORT.value

glassfishrobot commented 14 years ago

@glassfishrobot Commented sonymanuel said: The use case for us is to consistently retrieve the instance http/https/orb/jmx ports. This is used by the test framework for different test scenarios. Our cluster size varies from 2 - 10 so we don't want to hard-code/supply any values to create-instance.

Trying to get from servers.server.instance101.* is not working for all the instances.

ejp5360-vm1:/space/sony/builds/gfv3.1/glassfish # asadmin get servers.server.instance101.system-property.HTTP_LISTENER_PORT.value remote failure: Dotted name path servers.server.instance101.system-property.HTTP_LISTENER_PORT.value not found.

Command get failed. ejp5360-vm1:/space/sony/builds/gfv3.1/glassfish # asadmin get servers.server.instance102.system-property.HTTP_LISTENER_PORT.value remote failure: Dotted name path servers.server.instance102.system-property.HTTP_LISTENER_PORT.value not found.

Command get failed. ejp5360-vm1:/space/sony/builds/gfv3.1/glassfish # asadmin get servers.server.instance103.system-property.HTTP_LISTENER_PORT.value servers.server.instance103.system-property.HTTP_LISTENER_PORT.value=28081

Command get executed successfully. ejp5360-vm1:/space/sony/builds/gfv3.1/glassfish #

In GF 2.x the server instance value was returned if it was over-ridden. I think its better to keep it that way.

glassfishrobot commented 14 years ago

@glassfishrobot Commented tmueller said: Agreed.

glassfishrobot commented 14 years ago

@glassfishrobot Commented tmueller said: Vijay, any chance to get to this sooner rather than later?

glassfishrobot commented 14 years ago

@glassfishrobot Commented vijaysr said: Looks like this is a stopper for QE; bumping up priority

glassfishrobot commented 14 years ago

@glassfishrobot Commented ai109478 said: Here is the order for these property values:

config --> cluster --> instance

Properties defined under "cluster" overrides data defined under "config" element. Properties defined under "instance" overrides data defined under "cluster"

glassfishrobot commented 14 years ago

@glassfishrobot Commented vijaysr said: Fix checked in. Get command output obeys the following override rules. name, value pairs in config get overridden by those in cluster; the same in server element override cluster equivalent.

glassfishrobot commented 14 years ago

@glassfishrobot Commented File: domain.xml Attached By: sonymanuel

glassfishrobot commented 14 years ago

@glassfishrobot Commented Was assigned to vijaysr

glassfishrobot commented 7 years ago

@glassfishrobot Commented This issue was imported from java.net JIRA GLASSFISH-12917

glassfishrobot commented 14 years ago

@glassfishrobot Commented Reported by sonymanuel

glassfishrobot commented 14 years ago

@glassfishrobot Commented Marked as fixed on Friday, August 20th 2010, 5:47:20 am