eclipse-ee4j / glassfish

Eclipse GlassFish
https://eclipse-ee4j.github.io/glassfish/
376 stars 143 forks source link

create-domain customization step is failing #13689

Closed glassfishrobot closed 13 years ago

glassfishrobot commented 13 years ago

The create-domain customization step is failing. This is the output from create-domain:

Domain.xml customization failed : java.lang.RuntimeException: No runtime builder for this configuration: {-type=EMBEDDED, hk2.startup.context.moduleStartup=Doma inCreation, com.sun.aas.installRootURI=file:/C:/test/glassfishv3/glassfish/, Gla ssFish_Platform=Static, com.sun.aas.configFileURI=file:/C:/test/glassfishv3/glas sfish/domains/domain2/config/domain.xml, com.sun.aas.installRoot=C:\test\glassfi shv3\glassfish}

Environment

Operating System: All Platform: All

Affected Versions

[3.1]

glassfishrobot commented 5 years ago
glassfishrobot commented 13 years ago

@glassfishrobot Commented tmueller said: I've traced this failure into the embedded API. Specifically, the EmbeddedNonOSGiGlassFishRuntimeBuilder does not handle the case where the properties are pointing to a valid install root.

Suggested fix:

Change line 94 in EmbeddedNonOSGiGlassFishRuntimeBuilder to:

if (isValidInstallRoot(installRoot)) {

(There is a ! before isValidInstallRoot now).

Also, add the following line to CreateDomainCommand.java (at line 828):

properties.setProperty("-domain", domainConfig.getDomainName());

glassfishrobot commented 13 years ago

@glassfishrobot Commented tmueller said: Fixed in revision 41656.

glassfishrobot commented 13 years ago

@glassfishrobot Commented Was assigned to tmueller

glassfishrobot commented 7 years ago

@glassfishrobot Commented This issue was imported from java.net JIRA GLASSFISH-13689

glassfishrobot commented 13 years ago

@glassfishrobot Commented Reported by tmueller

glassfishrobot commented 13 years ago

@glassfishrobot Commented Marked as fixed on Tuesday, October 12th 2010, 1:43:40 am