deploy/undeploy to DAS fail if there are clusters, but no clustering software

[glassfishrobot]

This is related to feature CONFIG-008 (issue 12023) which states that even if there is cluster information in the domain.xml file, the DAS should behave normally even if the cluster software is uninstalled.

Here is a test case where that breaks:

asadmin start-domain asadmin create-cluster c1 asadmin stop-domain rm glassfish3/glassfish/modules/cluster-admin.jar asadmin start-domain asadmin deploy someapp.war asadmin undeploy someapp

The undeploy will fail because it tries to access a class in the cluster- admin.jar file, but it can't:

Unsatisfied dependency exception : private org.glassfish.api.admin.ClusterExecutor org.glassfish.api.admin.ExecuteOn$TargetBasedExecutor.delegate

Environment

Operating System: All Platform: All

Affected Versions

[3.1]

[glassfishrobot]

• Issue Imported From: https://github.com/javaee/glassfish/issues/13838
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @yaminikb
• Original Issue Closed By:@glassfishrobot

[glassfishrobot]

@glassfishrobot Commented vijaysr said: scrub scrub

[glassfishrobot]

@glassfishrobot Commented @honghzzhang said: change to admin category as this is in admin code

[glassfishrobot]

@glassfishrobot Commented vijaysr said: A fix for this can be put in but that will be ugly code. Before doing that, I would like to raise a question, is this a valid bug ?

1. I install GF; remove cluster-admin.jar; deploy, undeploy on DAS goes through just fine

2. I install GF; create clusters, create instances, do whatever, cleanup all those clusters and instances; After the cleanup of all those clusters and instances, I remove cluster-admin.jar; Now, deploy and undeploy on DAS goes through just fine.

3. Only in the case, where I create clusters, instances; remove cluster-admin.jar; try deploy/undeploy on DAS, this error is displayed. But still if you see deploy, undeploy goes through just fine. This error is an indication that something is wrong - in the presence of clusters and instances, the framework finds that it is missing something. The fact that this happens for undeploy only and not for deploy is because of some impl details of deployment which is a special case. Note that in spite of this error, undeploy on DAS went through just fine.

Given this, I am not sure if we should fix this error. If the DAS has some clusters and instances, then the absence of this JAR will be known with any commands that get executed (except deploy command because of some quirks).

I am tempted to close this as INVALID - comments ?

[glassfishrobot]

@glassfishrobot Commented tmueller said: See requirement CONFIG-008, also issue 12023. http://wikis.sun.com/display/GlassFish/3.1Config

Specifically, part of the DAS operating normally in the description if issue 12023 is being able to deploy and undeploy an application to/from the DAS.

[glassfishrobot]

@glassfishrobot Commented vijaysr said: To fix this scenario, UnsatisfiedDependencyException is caught and logged as WARNING message in server.log. The command will not get a WARNING result - it will get SUCCESS as a result from DAS. The unit tests and QLs are passing. The only concern is, if there is UnsatisifiedDependencyException because of this some other problem, then the commands will keep passing with WARNING messages being logged in server.log.

[glassfishrobot]

@glassfishrobot Commented Was assigned to vijaysr

[glassfishrobot]

@glassfishrobot Commented This issue was imported from java.net JIRA GLASSFISH-13838

[glassfishrobot]

@glassfishrobot Commented Reported by tmueller

[glassfishrobot]

@glassfishrobot Commented Marked as fixed on Wednesday, October 27th 2010, 7:43:54 am