Closed glassfishrobot closed 12 years ago
glassfishrobot
commented
6 years ago glassfishrobot
commented
13 years ago @glassfishrobot Commented scatari said: Please see http://java.net/jira/browse/GLASSFISH-14109 for more information on the original request. As commented in 14109, this release will include clusterjsp in binary format and the build scripts will be added in 3.2 due to time constraints.
It is important to give developers the access to this sample, removing the sample from distribution will defeat that.
This sample even though lacking the build system, serves the purpose. Add to that if someone tries to build this sample using standard ant tasks, then a clear message gets displayed regarding the support level in this release.
clusterjsp build does not include any compilable artifacts, hence can be disassembed and assembled by developers easily.
Adding "exclude" to be fixed in 3.2.
glassfishrobot
commented
13 years ago @glassfishrobot Commented scatari said: Please see http://java.net/jira/browse/GLASSFISH-14109 for more information on the original request. As commented in 14109, this release will include clusterjsp in binary format and the build scripts will be added in 3.2 due to time constraints.
It is important to give developers the access to this sample, removing the sample from distribution will defeat that.
This sample even though lacking the build system, serves the purpose. Add to that if someone tries to build this sample using standard ant tasks, then a clear message gets displayed regarding the support level in this release.
clusterjsp build does not include any compilable artifacts, hence can be disassembed and assembled by developers easily.
Adding "exclude" to be fixed in 3.2.
glassfishrobot
commented
13 years ago @glassfishrobot Commented scatari said: Not critical for product functionality. Targeting for post 3.1.1 release.
glassfishrobot
commented
13 years ago @glassfishrobot Commented scatari said: Romain, Please evaluate this further to be fixed in 3.1.2.
glassfishrobot
commented
12 years ago @glassfishrobot Commented @romain-grecourt said: version 1.1 of samples has been released. This version was integrated into samples's trunk and 3.1.2 branche today. Fixed samples will available by next promoted build (#17).
glassfishrobot
commented
12 years ago @glassfishrobot Commented ap2257 said: Unable to deploy sample, thus, re-opening the bug. The ant targets for compile, package and clean work without failure, however, when I execute "ant run", I see the following error:
-pre-deploy: [exec] Result: 1 [delete] Deleting: /home/ap2257/workspace/glassfish3/glassfish/samples/javaee6/ha/clusterjsp/asadmin-get-output [exec] Result: 1 [delete] Deleting: /home/ap2257/workspace/glassfish3/glassfish/samples/javaee6/ha/clusterjsp/asadmin-get-output
deploy: [exec] Deprecated syntax, instead use: [exec] asadmin --user admin --passwordfile /home/ap2257/workspace/glassfish3/glassfish/samples/bp-project/passwordfile --host localhost --port 4848 deploy [options] ... [exec] remote failure: Unable to find a valid target with name cluster [exec] Command deploy failed.
BUILD FAILED /home/ap2257/workspace/glassfish3/glassfish/samples/bp-project/app-server-ant.xml:605: exec returned: 1
The issue appears that clusterjsp expects to deploy on a cluster that is not being created by ant targets.
glassfishrobot
commented
12 years ago @glassfishrobot Commented @romain-grecourt said: The cluster and the 2 instances needed to run this sample are currently configured using "setup" targets from "clusterjsp" directory. You need to run the following targets to be able to run this sample: "ant setup run" (as run calls package).
Be careful as if you ran the sample without having ran "setup", it means that you deployed the "clusterjsp" application on the DAS. Then when running "ant setup run", deployment to cluster will fail because the application will be already deployed on DAS.
You'll have to delete and re-create domain1 before trying again (because of some application ref). I think we need to prevent that usecase. I see some solutions:
Or I've just missed something in the changes I made, please let me know.
glassfishrobot
commented
12 years ago @glassfishrobot Commented ap2257 said: Because you've added targets to this sample, I believe you need to update the Clusterjsp instructions located for example at /export/test/glassfish3/glassfish/samples/javaee/ha/clusterjsp/docs/index.html, and list the sequence of ant targets that showcase this sample. The current instructions are all manual and the point to the pre-compiled version of the sample (clusterjsp.ear).
glassfishrobot
commented
12 years ago @glassfishrobot Commented @romain-grecourt said: What is the impact on the customer of the bug?
User following instructions will not be able to run the sample.
What is the cost/risk of fixing the bug? The fix is very simple: documenting the steps.
Is there an impact on documentation or message strings? No.
Which tests should QA (re)run to verify the fix did not destabilize GlassFish? Try to run the sample again.
Which is the targeted build of 3.1.2 for this fix? b20.
glassfishrobot
commented
12 years ago @glassfishrobot Commented junesm said: This issue has been removed from the list of 3.1.2 Release Note issues. I have no objection, I'm just curious why.
glassfishrobot
commented
12 years ago @glassfishrobot Commented @romain-grecourt said: I removed the release note tags because I thought that the fix will remove the need of a release note. Please feel free to put the tags back if you think it would still need a release note.
glassfishrobot
commented
12 years ago @glassfishrobot Commented ap2257 said: A few of points
1. We should remove this issue from the Release Notes, because the initial problem reported by me is now fixed.
2. In the justification section, it says no impact to documentation, but that is not true. I pointed out that we need to update/edit the samples/javaee/ha/clusterjsp/docs/index.html and I believe this constitutes a change in the product and adds some risk if mistakes are made.
3. It's not quite true that all QA has to do is run the sample again. The change will require that QA verify the instructions of how to build/compile/deploy the sample. So, there's a bit more impact on QA than stated.
glassfishrobot
commented
7 years ago @glassfishrobot Commented This issue was imported from java.net JIRA GLASSFISH-15467
glassfishrobot
commented
13 years ago @glassfishrobot Commented Reported by ap2257
glassfishrobot
commented
12 years ago @glassfishrobot Commented Marked as fixed on Wednesday, February 1st 2012, 8:03:04 am
Recently a new sample was added to the SDK distributions - clusterjsp, however, the contents of this sample are not consistent with the other samples. Clusterjsp is missing targets to compile, package, run and cleanup in build.xml.
Given the timing of this release, the suggestion is that we remove this sample from the GF3.1 SDK distributions.
Environment
SDK build 35/36. Glassfish distribution
Affected Versions
[3.1_dev]