[Regression] Executed create-node-config without -node, then create-instance has to fail.

[glassfishrobot]

AIX 6.1 glassfish 3.1.1, build 04.

Executed the follow commands:

asadmin create-node-config test_node1 Command create-node-config executed successfully.

asadmin create-instance --node test_node1 test_inst1 Port Assignments for server instance test_inst1: JMS_PROVIDER_PORT=27677 JAVA_DEBUGGER_PORT=29010 HTTP_SSL_LISTENER_PORT=28182 IIOP_SSL_MUTUALAUTH_PORT=23921 HTTP_LISTENER_PORT=28081 OSGI_SHELL_TELNET_PORT=26667 JMX_SYSTEM_CONNECTOR_PORT=28687 ASADMIN_LISTENER_PORT=24849 IIOP_SSL_LISTENER_PORT=23821 IIOP_LISTENER_PORT=23701 The instance test_inst1 was registered with the DAS. You must run the following comand on the instance host to complete the instance creation: asadmin --host aixas13.us.oracle.com --port 4848 create-local-instance --node test_node1 test_inst1 Command create-instance executed successfully.

When I've executed the same test against glassfish 3.1 b43, I saw such output from that create-instance command:

remote failure: Node test_node1 does not have the nodehost attribute set and therefore create-instance can not be used with this node. You must either add the nodehost attribute using the update-node-config command, or create the instance by running create-local-instance directly on the instance host. Command create-instance failed.

I believe 3.1 FCS behavior was correct, but now the instance was not really created, but still exists.

Affected Versions

[3.1.1_dev]

[glassfishrobot]

• Issue Imported From: https://github.com/javaee/glassfish/issues/16580
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @carlavmott
• Original Issue Closed By:@glassfishrobot

[glassfishrobot]

@glassfishrobot Commented tmueller said: This issue appears to have the same root cause as #16579, i.e., revision 44848 remove the checks to see if the required attributes are set in the node before running create-instance.

[glassfishrobot]

@glassfishrobot Commented @carlavmott said: I don't think this is a bug. In 3.1 nodehost was required as was installdir. We always knew where to create the instance. In 3.2 we allow config nodes that are for the offline case and nodehost is not required. If not specified then we don't know if the instance is to be created on the localhost or a remote host.

The use case where the use should create a config node with no nodehost is the offline case and the user doesn't know the name of the host where it will be created. At some point the host name is known and should be supplied before creating the instance using create-instance.

[glassfishrobot]

@glassfishrobot Commented easarina said: As I've wrote, the same test was executed against 3.1 FCS build. For that build create-node-config did not require nodehost, bur in this case create-instance gave a correct error message. Now nothing gave a user any hint that something was wrong at the previous step.

[glassfishrobot]

@glassfishrobot Commented @carlavmott said: I just ran the commands on 3.1.1 workspace and see that an error message is printed when the user runs create-instance and the node doesn't have a nodehost or installdir set. See below for the error message. Are you saying you want a different error message? I don't understand what the problem is as the system is working as expected.

cmott$ asadmin create-node-config node1 Command create-node-config executed successfully. cmott$ asadmin create-instance --node node1 test-i1Port Assignments for server instance test-i1: JMX_SYSTEM_CONNECTOR_PORT=28686 JMS_PROVIDER_PORT=27676 HTTP_LISTENER_PORT=28080 ASADMIN_LISTENER_PORT=24848 JAVA_DEBUGGER_PORT=29009 IIOP_SSL_LISTENER_PORT=23820 IIOP_LISTENER_PORT=23700 OSGI_SHELL_TELNET_PORT=26666 HTTP_SSL_LISTENER_PORT=28181 IIOP_SSL_MUTUALAUTH_PORT=23920 The instance test-i1 was registered with the DAS. You must run the following comand on the instance host to complete the instance creation: asadmin --host dhcp-santaclara22-1fl-west-10-132-181-68.usdhcp.oraclecorp.com --port 4848 create-local-instance --node node1 test-i1 Command create-instance executed successfully.

[glassfishrobot]

@glassfishrobot Commented @carlavmott said: In 3.1.1 and beyond, it is no longer required for config nodes to have a nodehost or installdir parameter specified. In that case, if the user then runs create-instance the user will get an error message. If only nodehost is specified then the config element is created and the status will be success but the user must create the instance file system using create-local-instance command. The other option is for the user to update the node to include the nodehost and then rerun create-instance command.

[glassfishrobot]

@glassfishrobot Commented This issue was imported from java.net JIRA GLASSFISH-16580

[glassfishrobot]

@glassfishrobot Commented Reported by easarina

[glassfishrobot]

@glassfishrobot Commented Marked as works as designed on Friday, May 13th 2011, 8:11:57 am