Sniffers are getting loaded early

[glassfishrobot]

I don't see any reason for this class to exist. We should defer initialization of sniffers to first application deployment. /**

• Optimization to force the loading of sniffers post deployment.
• Sniffers can be slow to load and should not delay server statup when
• no application is deployed. / @Service @PostStartupRunLevel public class PostInitializer implements PostConstruct {

@Inject SnifferManager sniffers;

public void postConstruct()

{ sniffers.getCompositeSniffers(); sniffers.getSniffers(); }

}

Affected Versions

[4.0_dev]

[glassfishrobot]

• Issue Imported From: https://github.com/javaee/glassfish/issues/18633
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @honghzzhang
• Original Issue Closed By:@glassfishrobot

[glassfishrobot]

@glassfishrobot Commented @honghzzhang said: From the svn log message, Jerome added this for performance improvement? Is this no longer applicable in the current code?

r32996 | dochez | 2009-10-20 13:06:15 -0400 (Tue, 20 Oct 2009) | 7 lines

Deployment performance improvement by reducing the sniffer loading time (reducin g the imported bundle list) moved WebServicesSniffer to a new module to avoid resolving the entire web servi ces stack for any deployment IT 10256 : hk2 lookup used on invocation path (reviewed by Ken Saks) IT 10069 : incremental fix for app name registration in embedded mode turned off autodeploy in embedded mode by default.

[glassfishrobot]

@glassfishrobot Commented ss141213 said: I can't see that improving performance except for first deployment. Instead of loading during first deployment, we are loading early defeating lazy initialization. So, pl. remove it.

[glassfishrobot]

@glassfishrobot Commented @honghzzhang said: Remove PostInitializer as sugguested (checked with Scott/Tom also).

[glassfishrobot]

@glassfishrobot Commented This issue was imported from java.net JIRA GLASSFISH-18633

[glassfishrobot]

@glassfishrobot Commented Reported by ss141213

[glassfishrobot]

@glassfishrobot Commented Marked as fixed on Friday, March 8th 2013, 8:17:07 am