Closed glassfishrobot closed 11 years ago
@glassfishrobot Commented @ssevozen said: I think we'll need to add branding module which will override branding properties file to appserver workspace. I'll try to get this in by b83.
@glassfishrobot Commented @ssevozen said:
Regression compared to previous releases and significant branding issue.
Low/moderate risk. Very limited impact on product runtime, but fix does span multiple components (need to create appserver specific branding fragment module with appropriate values and integrate that module into packager).
No.
Admin GUI visual verification, possibly asadmin version subcommand regression testing.
b85
N/A
@glassfishrobot Commented tmueller said: I'm not seeing this in my private builds. The content of the glassfish-version.properties file is:
product_name=GlassFish Server Open Source Edition brief_product_name=GlassFish Server abbrev_product_name=glassfish major_version=4 minor_version=0 update_version= build_id=tomuell-private version_prefix= version_suffix= default_domain_template=appserver-domain.jar admin_client_command_name=asadmin
The source file (appserver/packager/appserver-base/src/main/resources/config/branding/glassfish-version.properties) has:
product_name=$
{product.name}
brief_product_name=$
{brief_product_name}
abbrev_product_name=$
{abbrev_product_name}
major_version=$
{major_version}
minor_version=$
{minor_version}
update_version=$
{update_version}
build_id=$
{build.id}
version_prefix=$
{version_prefix}
version_suffix=$
{version_suffix}
default_domain_template=$
{default_domain_template}
admin_client_command_name=$
{admin_client_command_name}
Product name is set to GlassFish in the appserver/pom.xml file:
@glassfishrobot Commented tmueller said: A fix for this issue is approved for 4.0. However, it appears that more analysis is required to understand where the problem actually is.
Also, the distribution that actually has this should be identified (the description doesn't do this).
@glassfishrobot Commented jclingan said: Tom, I pull this from svn directly:
svn checkout https://svn.java.net/svn/glassfish~svn/trunk/main
I wasn't sure if this was leaking into another build, and that makes it a P1. Regardless, BG Server shouldn't exist anywhere in the trunk, and that would be a P2.
@glassfishrobot Commented @ssevozen said: This turned out to be a red herring of a sort. So far we are unable to reproduce this with any of RE produced builds or with two developer build setups (Tom's and mine). So, closing as non-reproducible.
@glassfishrobot Commented This issue was imported from java.net JIRA GLASSFISH-19881
@glassfishrobot Commented Reported by jclingan
@glassfishrobot Commented Marked as cannot reproduce on Thursday, April 11th 2013, 3:32:57 pm
/appserver/distributions/glassfish/target/dependency/glassfish4/glassfish/config/branding/glassfish-version.properties contains "BG Server" as the product name property. This appears in the browser when booting the admin console "Starting BG Server 4.0". This should be changed, likely to "GlassFish Server Open Source Edition" if this belongs to the open source branding module.
Environment
N/A
Affected Versions
[4.0_dev]