Compilation warning in web-core

eclipse-ee4j / glassfish

Eclipse GlassFish

https://eclipse-ee4j.github.io/glassfish/

382 stars 143 forks source link

Compilation warning in web-core #20183

Closed glassfishrobot closed 11 years ago

glassfishrobot commented 11 years ago

While compiling web-core, we see the following:

[WARNING] /export/gf4/src/all/main/appserver/web/web-core/src/main/java/org/apache/catalina/loader/WebappLoader.java:[952,18] [unchecked] unchecked conversion [WARNING] required: PrivilegedExceptionAction found: where T is a type-variable: T extends Object declared in method doPrivileged(PrivilegedExceptionAction) /export/gf4/src/all/main/appserver/web/web-core/src/main/java/org/apache/catalina/loader/WebappLoader.java:[951,41] [unchecked] unchecked method invocation: method doPrivileged in class AccessController is applied to given types [WARNING] required: PrivilegedExceptionAction found: where T is a type-variable: T extends Object declared in method doPrivileged(PrivilegedExceptionAction)

The above new code is introduced in svn 61113 for GlassFish-20035.

Adding generic will solve the issue.

glassfishrobot commented 6 years ago

Issue Imported From: https://github.com/javaee/glassfish/issues/20183
Original Issue Raised By:@glassfishrobot
Original Issue Assigned To: @shingwaichan
Original Issue Closed By:@glassfishrobot

glassfishrobot commented 11 years ago

@glassfishrobot Commented @shingwaichan said:

What is the impact on the customer of the bug? No.
What is the cost/risk of fixing the bug? Add generic. It is a one line change.
Is there an impact on documentation or message strings? No.
Which tests should QA (re)run to verify the fix did not destabilize GlassFish? No.
Which is the targeted build of 4.0 for this fix? 4.0_b85
If this an integration of a new version of a component from another project, what are the changes that are being brought in? This might be list of Jira issues from that project or a list of revision messages. N/A

glassfishrobot commented 11 years ago

@glassfishrobot Commented @shingwaichan said: Sending web-core/src/main/java/org/apache/catalina/loader/WebappLoader.java Transmitting file data . Committed revision 61182.

glassfishrobot commented 11 years ago

@glassfishrobot Commented @shingwaichan said: I also notice the following compilation warning in war-util.

WARNING] /export/gf4/src/all/main/appserver/web/war-util/src/main/java/com/sun/enterprise/glassfish/web/WarHandler.java:[217,24] [unchecked] unchecked conversion [WARNING] required: PrivilegedExceptionAction found: SetPermissionsAction where T is a type-variable: T extends Object declared in method doPrivileged(PrivilegedExceptionAction)

It is also a generic issue. The fix is in security module as follows: Revisions:

61203

Modified Paths:

trunk/main/appserver/security/core-ee/src/main/java/com/sun/enterprise/security/perms/PermsArchiveDelegate.java

glassfishrobot commented 7 years ago

@glassfishrobot Commented This issue was imported from java.net JIRA GLASSFISH-20183

glassfishrobot commented 11 years ago

@glassfishrobot Commented Reported by @shingwaichan

glassfishrobot commented 11 years ago

@glassfishrobot Commented Marked as fixed on Tuesday, April 9th 2013, 9:32:17 am