search

eclipse-ee4j / glassfish

Eclipse GlassFish
https://eclipse-ee4j.github.io/glassfish/
386 stars 145 forks source link

Refactor com.sun.* classes to org.glassfish.main #23627

Open arjantijms opened 3 years ago

arjantijms commented 3 years ago

GlassFish uses a mix of org.glassfish and com.sun.* packages. For consistency, and because Eclipse doesn't own com.sun or the domain sun.com it may be better to refactor everything to org.glassfish.*. This may however be quite an operation.

There's also a bunch of technically internal classes exposed in things like domain.xml starting with com.sun.

dmatej commented 3 years ago

I agree, but it should be done in some iterative process, because there is pretty much of "magical" reflection. In each iteration we need to pass all available tests (including those obsoleted, TCK, javaee-samples, ... I burned my fingers just with changing names of generated interfaces.

github-actions[bot] commented 2 years ago

This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment

dmatej commented 2 years ago

I think that the time is close. Just one question:org.glassfish or org.glassfish.main? Because there is many side projects which use org.glassfish too. Or it could be org.glassfish.server. Or org.gf. :-)

arjantijms commented 2 years ago

org.glassfish.main probably. Not that it's such a good name, but all the other packages use it.

github-actions[bot] commented 1 year ago

This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment

github-actions[bot] commented 1 week ago

This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment

arjantijms commented 1 week ago

We may still want to do this. One day.