Message catalog key not transformed: using.default.ds

eclipse-ee4j / glassfish

Eclipse GlassFish

https://eclipse-ee4j.github.io/glassfish/

384 stars 143 forks source link

Message catalog key not transformed: using.default.ds #23873

Closed mheydem closed 2 years ago

mheydem commented 2 years ago

Environment Details

GlassFish Version (and build number): Glassfish 6.0 Release
JDK version: corretto jdk1.8.0_322
OS: Windows 10

Problem Description

This message appears in my server.log:

[2022-03-29T13:06:44.563+0000] [glassfish 6.0] [WARNING] [] [javax.enterprise.resource.resourceadapter.org.glassfish.jdbcruntime] [tid: _ThreadID=33 _ThreadName=RunLevelControllerThread-1648559203407] [timeMillis: 1648559204563] [levelValue: 900] [[
  using.default.ds]]

A more meaningful text like this is expected: RAR8068: Using default datasource : {0} for pool : {1}

This issue was fixed for Payara. Glassfish could have this fix, too. https://github.com/payara/Payara/issues/502

Steps to reproduce

Not sure. I guess using a jdbc resource adapter can trigger this.

Impact of Issue

This issue does not to hurt functionality, but animates developers to waste time on useless investigation.

arjantijms commented 2 years ago

@dmatej as that was your original work back then, would you like to look at this again?

mheydem commented 2 years ago

I was able to narrow down the problem. It occurs in connection with a custom AuditModule. I think the fix or this particular constellation is not of public interest. That is why I am closing this bug report. Thank you for your help. If I find something interesting, I will share it with you.

dmatej commented 2 years ago

Ok, it is in my list in GF too :)

mheydem commented 2 years ago

I was able to reproduce this by extending domain.xml of the default domain1:

adding a <jdbc-connection-pool res-type="javax.sql.XADataSource" datasource-classname="oracle.jdbc.xa.client.OracleXADataSource" name="OracleConnectionPool">
adding a <jdbc-resource pool-name="OracleConnectionPool" jndi-name="jdbc/oracle">
adding an application(or custom audit module) which accesses the jdbc-resource via jndi
make sure the oracle libs are NOT provided to glassfish (for example ojdbc8.jar)

@dmatej Can you create the symptoms in the same way?

dmatej commented 2 years ago

I remember it was depending on the classloader and when Sun+Oracle started refactoring for GF3, they sometimes forgot to move the line, sometimes they did not notice that resources depend on the CL used, so once it works, when using app CL, it doesn't. I fixed that by some refactoring, where I added method to LogDomains and moved some things around. Maybe I will have some time tomorrow and I will do that in GlassFish again.