eclipse-ee4j / glassfish

Eclipse GlassFish
https://eclipse-ee4j.github.io/glassfish/
386 stars 145 forks source link

Remove target from create-jdbc-pool and delete-jdbc-pool #24171

Open dmatej opened 2 years ago

dmatej commented 2 years ago

What

  1. It is deprecated for a long time (15 years or so)
  2. Confuses user
  3. It was still there because some tests used it. When I deleted that, tests crashed, but now it is simple to find these tests and fix them.

How

  1. Remove it
  2. Find and remove it from tests
  3. Find and remove it from documentation
dmatej commented 2 years ago

Note: Resources can be linked to instances/clusters with create-resource-ref command. But pools and resources are always bound to the server instance (domain, admin ... we should consolidate this terminology too, perhaps for GF8 :-) ).

github-actions[bot] commented 1 year ago

This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment

github-actions[bot] commented 1 week ago

This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment

OndroMih commented 23 hours ago

Note that this issue is about create-jdbc-connection-pool and delete-jdbc-connection-pool, where the target attribute is deprecated and ignored. Connection pools are created for the whole domain. The target attribute still works for create-jdbc-resource. -The *-jdbc-resource commands map the connection pool a JNDI name and create a resource reference to map it to the DAS by default, or to the target specified as argument. Additional references can be created with create-resource-ref.

So:

dmatej commented 22 hours ago

Note that this issue is about create-jdbc-connection-pool and delete-jdbc-connection-pool, where the target attribute is deprecated and ignored. Connection pools are created for the whole domain. The target attribute still works for create-jdbc-resource. -The *-jdbc-resource commands map the connection pool a JNDI name and create a resource reference to map it to the DAS by default, or to the target specified as argument. Additional references can be created with create-resource-ref.

So:

  • connection pool - a single instance for the whole domain. Specifies the connection properties and pool properties
  • JDBC resource - one or more instance for whole domain - maps a connection pool to a JNDI name
  • resource reference - a single instance for a target and a JDBC resource - mapping between a JNDI name and a target. A single JDBC resource can have multiple references (can be bound to multiple targets)

That is what I meant by the first comment. I don't know why I did not write it directly to the description.