FindBugs changes: fix complaints about admin code

glassfishrobot commented 17 years ago

This bug is a placeholder for changes in various places in admin and admin-related code.

Environment

Operating System: All Platform: All

Affected Versions

[9.1pe]

glassfishrobot commented 6 years ago

Issue Imported From: https://github.com/javaee/glassfish/issues/2752
Original Issue Raised By:@glassfishrobot
Original Issue Assigned To: @yaminikb
Original Issue Closed By:@glassfishrobot

glassfishrobot commented 17 years ago

@glassfishrobot Commented llc said: Changes will be committed in batches. First one--

Checking in commands/src/java/com/sun/enterprise/cli/commands/CreateDomainCommand.java; /cvs/glassfish/admin-cli/commands/src/java/com/sun/enterprise/cli/commands/ CreateDomainCommand.java,v <-- CreateDomainCommand.java new revision: 1.23; previous revision: 1.22 done Checking in commands/src/java/com/sun/enterprise/cli/commands/DomainReporter.java; /cvs/glassfish/admin-cli/commands/src/java/com/sun/enterprise/cli/commands/ DomainReporter.java,v <-- DomainReporter.java new revision: 1.5; previous revision: 1.4 done Checking in commands/src/java/com/sun/enterprise/cli/commands/HelpCommand.java; /cvs/glassfish/admin-cli/commands/src/java/com/sun/enterprise/cli/commands/ HelpCommand.java,v <-- HelpCommand.java new revision: 1.4; previous revision: 1.3 done Checking in commands/src/java/com/sun/enterprise/cli/commands/S1ASCommand.java; /cvs/glassfish/admin-cli/commands/src/java/com/sun/enterprise/cli/commands/ S1ASCommand.java,v <-- S1ASCommand.java new revision: 1.35; previous revision: 1.34 done Checking in framework/src/java/com/sun/enterprise/cli/framework/LocalStringsManager.java; /cvs/glassfish/admin-cli/framework/src/java/com/sun/enterprise/cli/framework/ LocalStringsManager.java,v <-- LocalStringsManager.java new revision: 1.4; previous revision: 1.3 done

glassfishrobot commented 17 years ago

@glassfishrobot Commented llc said: Batch 2:

Checking in src/java/com/sun/enterprise/admin/servermgmt/launch/ASLauncher.java; /cvs/glassfish/admin/servermgmt/src/java/com/sun/enterprise/admin/servermgmt/launch/ ASLauncher.java,v <-- ASLauncher.java new revision: 1.13; previous revision: 1.12 done Checking in src/java/com/sun/enterprise/admin/servermgmt/launch/DASLauncher.java; /cvs/glassfish/admin/servermgmt/src/java/com/sun/enterprise/admin/servermgmt/launch/ DASLauncher.java,v <-- DASLauncher.java new revision: 1.2; previous revision: 1.1 done

glassfishrobot commented 17 years ago

@glassfishrobot Commented llc said: llc

glassfishrobot commented 17 years ago

@glassfishrobot Commented llc said: Batch 3: com/sun/enterprise/admin/selfmanagement

Checking in event/EventBuilder.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/selfmanagement/event/ EventBuilder.java,v <-- EventBuilder.java new revision: 1.7; previous revision: 1.6 done Checking in event/LifeCycleEventFactory.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/selfmanagement/event/ LifeCycleEventFactory.java,v <-- LifeCycleEventFactory.java new revision: 1.7; previous revision: 1.6 done Checking in event/LogEvent.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/selfmanagement/event/ LogEvent.java,v <-- LogEvent.java new revision: 1.5; previous revision: 1.4 done Checking in event/LogEventFactory.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/selfmanagement/event/ LogEventFactory.java,v <-- LogEventFactory.java new revision: 1.6; previous revision: 1.5 done Checking in event/MonitorEventFactory.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/selfmanagement/event/ MonitorEventFactory.java,v <-- MonitorEventFactory.java new revision: 1.11; previous revision: 1.10 done Checking in event/NotificationEvent.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/selfmanagement/event/ NotificationEvent.java,v <-- NotificationEvent.java new revision: 1.5; previous revision: 1.4 done Checking in event/NotificationEventFactory.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/selfmanagement/event/ NotificationEventFactory.java,v <-- NotificationEventFactory.java new revision: 1.8; previous revision: 1.7 done Checking in event/TimerEventFactory.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/selfmanagement/event/ TimerEventFactory.java,v <-- TimerEventFactory.java new revision: 1.6; previous revision: 1.5 done Checking in event/TraceEventFactory.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/selfmanagement/event/ TraceEventFactory.java,v <-- TraceEventFactory.java new revision: 1.3; previous revision: 1.2 done

glassfishrobot commented 17 years ago

@glassfishrobot Commented llc said: Checking in admin/common/JMXFileTransfer.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/common/JMXFileTransfer.java,v <-- JMXFileTransfer.java new revision: 1.4; previous revision: 1.3 done Checking in admin/common/NameParser.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/common/NameParser.java,v <-- NameParser.java new revision: 1.4; previous revision: 1.3 done Checking in admin/common/domains/registry/ContactData.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/common/domains/registry/ ContactData.java,v <-- ContactData.java new revision: 1.4; previous revision: 1.3 done Checking in admin/common/domains/registry/DomainEntry.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/common/domains/registry/ DomainEntry.java,v <-- DomainEntry.java new revision: 1.4; previous revision: 1.3 done Checking in admin/common/domains/registry/DomainRegistry.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/common/domains/registry/ DomainRegistry.java,v <-- DomainRegistry.java new revision: 1.4; previous revision: 1.3 done Checking in admin/server/core/jmx/nonssl/RMIMultiHomedServerSocketFactory.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/server/core/jmx/nonssl/ RMIMultiHomedServerSocketFactory.java,v <-- RMIMultiHomedServerSocketFactory.java new revision: 1.4; previous revision: 1.3 done Checking in admin/server/core/mbean/config/ManagedAdminServerInstance.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/server/core/mbean/config/ ManagedAdminServerInstance.java,v <-- ManagedAdminServerInstance.java new revision: 1.4; previous revision: 1.3 done Checking in admin/server/core/mbean/config/ModulesXMLHelper.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/server/core/mbean/config/ ModulesXMLHelper.java,v <-- ModulesXMLHelper.java new revision: 1.4; previous revision: 1.3 done Checking in admin/server/core/mbean/config/ServerController.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/server/core/mbean/config/ ServerController.java,v <-- ServerController.java new revision: 1.5; previous revision: 1.4 done Checking in admin/target/TargetBuilder.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/target/TargetBuilder.java,v <-- TargetBuilder.java new revision: 1.5; previous revision: 1.4 done Checking in admin/verifier/Result.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/verifier/Result.java,v <-- Result.java new revision: 1.4; previous revision: 1.3 done Checking in admin/verifier/ServerMgr.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/verifier/ServerMgr.java,v <-- ServerMgr.java new revision: 1.4; previous revision: 1.3 done Checking in admin/verifier/tests/StaticTest.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/verifier/tests/StaticTest.java,v <-- StaticTest.java new revision: 1.4; previous revision: 1.3 done Checking in deployment/autodeploy/JBIAutoDeployer.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/deployment/autodeploy/ JBIAutoDeployer.java,v <-- JBIAutoDeployer.java new revision: 1.5; previous revision: 1.4 done Checking in diagnostics/TargetType.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/diagnostics/TargetType.java,v <-- TargetType.java new revision: 1.5; previous revision: 1.4 done Checking in instance/BaseManager.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/instance/BaseManager.java,v <-- BaseManager.java new revision: 1.16; previous revision: 1.15 done Checking in launcher/StatusProber.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/launcher/StatusProber.java,v <-- StatusProber.java new revision: 1.4; previous revision: 1.3 done Checking in loader/ClassLoaderUtils.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/loader/ClassLoaderUtils.java,v <-- ClassLoaderUtils.java new revision: 1.6; previous revision: 1.5 done Checking in loader/EJBClassLoader.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/loader/EJBClassLoader.java,v <-- EJBClassLoader.java new revision: 1.20; previous revision: 1.19 done Checking in management/selfmanagement/SelfManagementService.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/management/selfmanagement/ SelfManagementService.java,v <-- SelfManagementService.java new revision: 1.13; previous revision: 1.12 done

glassfishrobot commented 17 years ago

@glassfishrobot Commented llc said: [more files were committed yesterday, but I forgot to list them here]

Checking in src/java/com/sun/enterprise/iiop/AlternateIIOPAddressComponent.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/iiop/AlternateIIOPAddressComponent.java,v <-- AlternateIIOPAddressComponent.java new revision: 1.4; previous revision: 1.3 done Checking in src/java/com/sun/enterprise/iiop/AlternateIIOPAddressComponentHelper.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/iiop/ AlternateIIOPAddressComponentHelper.java,v <-- AlternateIIOPAddressComponentHelper.java new revision: 1.4; previous revision: 1.3 done Checking in src/java/com/sun/enterprise/naming/SerialContext.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/naming/SerialContext.java,v <-- SerialContext.java new revision: 1.10; previous revision: 1.9 done

glassfishrobot commented 17 years ago

@glassfishrobot Commented llc said: Checking in nodeagent/src/java/com/sun/enterprise/ee/nodeagent/InstanceStatus.java; /cvs/glassfish/admin-ee/nodeagent/src/java/com/sun/enterprise/ee/nodeagent/InstanceStatus.java,v <-- InstanceStatus.java new revision: 1.4; previous revision: 1.3 done Checking in nodeagent/src/java/com/sun/enterprise/ee/nodeagent/ProcessManager.java; /cvs/glassfish/admin-ee/nodeagent/src/java/com/sun/enterprise/ee/nodeagent/ ProcessManager.java,v <-- ProcessManager.java new revision: 1.3; previous revision: 1.2 done Checking in nodeagent/src/java/com/sun/enterprise/ee/nodeagent/mbeans/ NodeAgentDiagnostic.java; /cvs/glassfish/admin-ee/nodeagent/src/java/com/sun/enterprise/ee/nodeagent/mbeans/ NodeAgentDiagnostic.java,v <-- NodeAgentDiagnostic.java new revision: 1.2; previous revision: 1.1 done

glassfishrobot commented 17 years ago

@glassfishrobot Commented llc said: As nearly all admin issues have been addressed, closing this bug. New bugs can be filed individually.

glassfishrobot commented 17 years ago

@glassfishrobot Commented Was assigned to llc

glassfishrobot commented 7 years ago

@glassfishrobot Commented This issue was imported from java.net JIRA GLASSFISH-2752

glassfishrobot commented 17 years ago

@glassfishrobot Commented Reported by llc

glassfishrobot commented 17 years ago

@glassfishrobot Commented Marked as fixed on Thursday, May 17th 2007, 4:05:53 am

eclipse-ee4j / glassfish

FindBugs changes: fix complaints about admin code #2752

Environment

Affected Versions