eclipse-ee4j / glassfish

Eclipse GlassFish
https://eclipse-ee4j.github.io/glassfish/
386 stars 144 forks source link

OSGI changes cause grizzly classes to be added twice to the distribution #4553

Closed glassfishrobot closed 16 years ago

glassfishrobot commented 16 years ago

The following changes:

https://glassfish-svn.dev.java.net/source/browse/glassfish-svn/trunk/v3/distributions/external/grizzly-http/pom.xml?view=diff&rev=19309&p1=trunk/v3/distributions/external/grizzly-http/pom.xml&p2=trunk/v3/distributions/external/grizzly-http/pom.xml&r1=19308&r2=19309

cause grizzly classes to be duplicated inside grizzly-modules-...jar. When you install v3, you ends up with Grizzly classes located in both grizzly-** artifacts and grizzly-module.

One possible solution is to uses the already OSGI bundle from Grizzly workspace

and changes v3 to have a dependencies on that module instead of framework/http/comet, and export that OSGI module (might need some changes in grizzly pom.xml). The other solution is to not add grizzly's artifacts to the final distribution and only use the grizzly-modules.

Environment

Operating System: All Platform: All

Affected Versions

[V3]

glassfishrobot commented 6 years ago
glassfishrobot commented 16 years ago

@glassfishrobot Commented jfarcand said: The OSGI modules can be found here:

http://download.java.net/maven/2/com/sun/grizzly/grizzly-bundles/

Not a lot of users are using it with Apache Felix so some testing might be required.

glassfishrobot commented 16 years ago

@glassfishrobot Commented jfarcand said: Thanks Jerome for fixing the issue!

glassfishrobot commented 16 years ago

@glassfishrobot Commented jfarcand said: Oups ping pong. This is not fixed with the latest. Re-open and assign to jerome. We need to fix this for tp2.

glassfishrobot commented 16 years ago

@glassfishrobot Commented jfarcand said: I would think the best solution is to use the bundle from Grizzly directly and add the missing information:

http://download.java.net/maven/2/com/sun/grizzly/grizzly-cometd-webserver/1.7.3/

That one is already OSGI-enabled and should work with GlassFish. So the fix would consist of removing the grizzly module, and instead uses the grizzly bundle directly with any extra processing in v3.

glassfishrobot commented 16 years ago

@glassfishrobot Commented jfarcand said: Ping pong...

glassfishrobot commented 16 years ago

@glassfishrobot Commented Was assigned to dochez

glassfishrobot commented 7 years ago

@glassfishrobot Commented This issue was imported from java.net JIRA GLASSFISH-4553

glassfishrobot commented 16 years ago

@glassfishrobot Commented Reported by jfarcand

glassfishrobot commented 16 years ago

@glassfishrobot Commented Marked as fixed on Tuesday, April 22nd 2008, 11:58:20 pm