eclipse-ee4j / glassfish

Eclipse GlassFish
https://eclipse-ee4j.github.io/glassfish/
387 stars 144 forks source link

JspC not working as Ant task #5319

Closed glassfishrobot closed 15 years ago

glassfishrobot commented 16 years ago

Using glassfish v2ur2-b04 on fedora 8 with jdk 1.5.0_15.

Trying to compile jsp's using an ant task throws "The absolute uri: http://java.sun.com/jsp/jstl/core cannot be resolved in either web.xml or the jar files deployed with this application". Using the command line jspc binary in $

{APPSRV_HOME}/bin works, but calling it using the ant taskdef fails. In addition, command line invocation does not support the addWebXmlMappings option.

<target name="compile_jsps" depends="compile">

<mkdir dir="$

{GEN}" /> <mkdir dir="${GEN}

/src" /> <mkdir dir="$

{GEN}/WEB-INF" /> <mkdir dir="${GEN}

/WEB-INF/lib" />

<copy todir="$

{GEN}/WEB-INF">

<copy todir="${GEN}

"> <fileset dir="$

{WEB}" includes="*/.jsp" /> <fileset dir="${WEB}

" includes="*/.jspf" />

<copy todir="$

{GEN}/WEB-INF/lib">

<jasper2 validateXml="false" uriroot="${GEN}

" addWebXmlMappings="true" webXmlFragment="$

{GEN}/WEB-INF/generated_web.xml" compilerSourceVM="1.5" compilerTargetVM="1.5" outputDir="${GEN}

/src" verbose="9" />

<javac fork="true" debug="true" deprecation="true" destdir="$

{CLS}

" nowarn="false" source="1.5" target="1.5"> <src path="$

{GEN}

/src" />

Environment

Operating System: Linux Platform: Linux

Affected Versions

[9.1peur2]

glassfishrobot commented 6 years ago
glassfishrobot commented 16 years ago

@glassfishrobot Commented @honghzzhang said: Assign to Kin-man for initial evaluation.

glassfishrobot commented 16 years ago

@glassfishrobot Commented @honghzzhang said: -> Kin-man

glassfishrobot commented 16 years ago

@glassfishrobot Commented kchung said: And how is is a bug in Glassfish? The problem is mostly probably in your environment or your ant task. You'll need to do your own debugging.

glassfishrobot commented 16 years ago

@glassfishrobot Commented travbow said: Obviously you did not read the bug post. If you had you would have seen that I am including ALL of the jars in the glassfish-home/lib directory. Since the error states that http://java.sun.com/jsp/jstl/core cannot be resolved in either web.xml or the jar files deployed with this application, and since the appserv-jstl.jar library contains c.tld which defines that, obviously the JspC class is ignoring the classpath passed and simply looking in the WEB-INF/lib directory. The fact that JspC works at the command line means that the ant task behavior is different than the command line behavior, which it should NOT be. As I mentioned in the original post, arguments such as addWebXmlMappings do not work at the command line which it should, and the -schemas and -dtds command line switches should be available in the ant task (could be causing the error?). Please fix this and bring the ant task functionality and command line functionality into line with each other. And by the way I ALWAYS debug my own code to determine whether an issue is in my code or in the app server code BEFORE I post so I don't appreciate your snide remark.

glassfishrobot commented 16 years ago

@glassfishrobot Commented kchung said: JspC uses the classpath passed to it for Java compilations, and does not know if it is passed via CLI or an ant task. Since CLI works but not your ant task (which is not part of glassfish), I'm still not convinced that JspC is at fault.

If you think that command line options addWebXmlMappings is useful, you can send in a patch for a fix. I'll be happy to incorporate it in the next build.

glassfishrobot commented 16 years ago

@glassfishrobot Commented travbow said: Look, this is NOT my ant task, this is YOUR ant task. You own the code, I simply am trying to use it. Have you even tried to run JspC as an ant task? If not, you are not in a position to say whether it works or not. The class org.apache.jasper.JspC is an ant task from the tomcat project. I have been precompiling jsp's with this class as an ant task for several years and it works fine. Obviously when it was brought over into the glassfish project from tomcat something got broken and now it doesn't work. I will keep reopening this bug until I get some progress.

glassfishrobot commented 16 years ago

@glassfishrobot Commented jluehe said: Not required for prelude

glassfishrobot commented 15 years ago

@glassfishrobot Commented sanandal said: "Reclassifying as P4 because this issue is not deemed "must fix" for this v2.1 release whose primary release driver is SailFin. This issue will be scrubbed after this release and will be given the right priority for the next release."

glassfishrobot commented 15 years ago

@glassfishrobot Commented kchung said: The script to use jspc as an ant task is not part of glassfish release.

glassfishrobot commented 16 years ago

@glassfishrobot Commented Was assigned to kchung

glassfishrobot commented 7 years ago

@glassfishrobot Commented This issue was imported from java.net JIRA GLASSFISH-5319

glassfishrobot commented 16 years ago

@glassfishrobot Commented Reported by travbow

glassfishrobot commented 15 years ago

@glassfishrobot Commented Marked as won't fix on Thursday, January 29th 2009, 8:44:07 am