jms-host values are incorrect in domain.xml

glassfishrobot commented 15 years ago

OS: solaris build: 03/24 nightly build http://gf-hudson.sfbay/hudson/job/gf-trunk-build-nightly/131/artifact/bundles/

MQ was integrated to this nightly build. In the domain.xml, I saw the following:

I think the jms-host information above is not correct. And also, it should contain jms port infor. See domain.xml below in v2. <jms-service addresslist-behavior="random" addresslist-iterations="3" defa ult-jms-host="default_JMS_host" init-timeout-in-seconds="60" reconnect-attempts= "3" reconnect-enabled="true" reconnect-interval-in-seconds="5" type="EMBEDDED">

Environment

Operating System: All Platform: All

Affected Versions

[V3]

glassfishrobot commented 5 years ago

Issue Imported From: https://github.com/javaee/glassfish/issues/7433
Original Issue Raised By:@glassfishrobot
Original Issue Assigned To: @yaminikb
Original Issue Closed By:@glassfishrobot

glassfishrobot commented 15 years ago

@glassfishrobot Commented bnevins said: Stealing this issue from Kedar...

glassfishrobot commented 15 years ago

@glassfishrobot Commented bnevins said: The host is set to some crazy insane directory path with FIFTEEN levels of nesting!

How, EXACTLY, are you setting up your glassfish installation

glassfishrobot commented 15 years ago

@glassfishrobot Commented bnevins said: 1. When I install glassfish.zip I get the host set to "localhost"

2. Here is what is in the domain.xml from distributions/nucleus-base/lib/templates

- - - - note how there is a port element

3. Here is what is in the domain.xml from an unzipped glassfish.zip

=================

Whoa! What happened to the port?!?

glassfishrobot commented 15 years ago

@glassfishrobot Commented bnevins said: I can not fix this until you give the following information:

1) What file did you use for your installation - there are TWENTY SIX files in the URL you specified?

2) Write down EXACTLY what you did to install

glassfishrobot commented 15 years ago

@glassfishrobot Commented @ssevozen said: Byron,

I will take the liberty of reopening this, given that I harped about the exact same thing on dev@glassfish alias last week...

You will see this issue in any official, IPS enabled distribution coming out of RE build or any newly created domain. Difference between developer built glassfish.zip distribution and the other one is that glassfish.zip is still using 'static' domain config checked in into SVN repository whereas IPS enabled distributions uses the domain config created at build time using 'asadmin create-domain' command. So, something is definitely off with the domain creation and you should be able to reproduce it if you create another domain in your developer installation.

glassfishrobot commented 15 years ago

@glassfishrobot Commented bnevins said: Excellent explanation. Thanks. I will run create-domain and see what happens...

glassfishrobot commented 15 years ago

@glassfishrobot Commented @ssevozen said: FWIW, it seems that jms host value for some reason gets resolved to GF installation directory value by create-domain...

glassfishrobot commented 15 years ago

@glassfishrobot Commented sonialiu said: I installed this build http://gf-hudson.sfbay/hudson/job/gf-trunk-build-nightly/131/artifact/bundles/glassfish-v3-ea-b42-03_24_2009.zip I just unzip the bits to install it.

glassfishrobot commented 15 years ago

@glassfishrobot Commented bnevins said: Snjezana,

Do I have this right:

You run create-domain at packaging time. The resulting domain.xml gets packaged.

If that's the case then there is an issue.

com.sun.aas.hostName is normally used to replace the %%%HOST_NAME%%% token in the domain.xml template. Usually this is the real name of the computer – not localhost.

That would be bad in your case because a "bad" hostname will be set for everyone downloading the installation file.

I see 2 solutions, in order of preference:

(1) I simply change the %%%HOST_NAME%%% token to the static string "localhost" which should work in all cases for create-domain

(2) The token is explicitly set to "localhost" only for IPS stuff

glassfishrobot commented 15 years ago

@glassfishrobot Commented @ssevozen said: Your assumption is correct, whatever gets produced by 'asadmin create-domain' at build time gets packaged and has to be generic enough to work out of the box on any system where it gets installed...

Using localhost would be fine, IMO, unless there is some reason this will not work on MQ side of things...

glassfishrobot commented 15 years ago

@glassfishrobot Commented bnevins said: The hostname is now hard-coded to "localhost"

glassfishrobot commented 15 years ago

@glassfishrobot Commented Was assigned to bnevins

glassfishrobot commented 7 years ago

@glassfishrobot Commented This issue was imported from java.net JIRA GLASSFISH-7433

glassfishrobot commented 15 years ago

@glassfishrobot Commented Reported by sonialiu

glassfishrobot commented 15 years ago

@glassfishrobot Commented Marked as fixed on Thursday, March 26th 2009, 5:26:39 am

eclipse-ee4j / glassfish