eclipse-ee4j / grizzly

Grizzly
https://eclipse-ee4j.github.io/grizzly
Other
149 stars 70 forks source link

Remove bootclasspath/p option #2067

Closed pzygielo closed 5 years ago

pzygielo commented 5 years ago

If -Xbootclasspath points to non-existing entry, like in this case, nothing is reported/no warning from java is issued. But it does not prevent tests to complete successfully. Hence it seems to be unnecessary.

Fixes #2066

pzygielo commented 5 years ago

May I ask for review, please?

pzygielo commented 5 years ago

May I ask for review, please?

smillidge commented 5 years ago

Does this pass on JDK 8?

pzygielo commented 5 years ago

Does this pass on JDK 8?

It did: https://travis-ci.org/pzygielo/grizzly/builds/536606888#L443

pzygielo commented 5 years ago

Shall I do anything else to move it forward?

MattGill98 commented 5 years ago

My apologies pzygielo, I left this open while I investigated the errors in the build and forgot to come back to it