Aggregated fixes from Payara

eclipse-ee4j / grizzly

Grizzly

https://eclipse-ee4j.github.io/grizzly

Other

148 stars 69 forks source link

Aggregated fixes from Payara #2112

Closed dmatej closed 3 years ago

dmatej commented 3 years ago

Fixes #2016 and #2111

This is a aggregated PR of Payara's fork of 2.4.4, I hope I didn't skip anything. Current Payara 5.2020.7-SNAPSHOT with these commits in it's own patch of Grizzly passed following tests:

all Grizzly's own tests
all Payara's own tests
TCK - websockets
TCK - servlet
my private test using arquillian and Apache HTTP Client and customized reproducer from #2016
HTTP/2 Push reproducer "100 Delphines" (after reconfiguring Payara a bit to use 100 threads for HTTP or more)
- note - this test causes exceptions with Firefox (remote stream reset), but no exceptions on Chrome

Merge:

these changes were based on changes done in #2103 , which should be merged first. I will resolve conflicts after that.

dmatej commented 3 years ago

All commits are signed, but eclipsefdn/eca has different opinion - what can I do?

edbratt commented 3 years ago

I agree, it does appear you have signed all the commits and you do have a valid ECA. A committer can go ahead and merge, once a review has been completed.

All commits are signed, but eclipsefdn/eca has different opinion - what can I do?

dmatej commented 3 years ago

I tried even to match my name including czech letters č and ě, but it is still the same. I'm giving up fighting with the eclipsefdn/eca checker ... the PR is prepared to be merged now, I don't plan any other pushes except those which would come from reviews.

dmatej commented 3 years ago

I rebased the PR, the build will now fail here for two reasons:

npn is not released yet
I reenabled AlpnSupportTest, locally tested in following configurations (see npn/openjsse profiles, default is no profile -> using JDK's impl). Travis is using now obsoleted JDK8u151 which does not contain backported ALPN support from newer JDKs yet.
OpenJDK 8u275, openjsse 1.1.5 ... SUCCESS
OpenJDK 11.0.8, openjsse 1.1.5 ... FAIL ... as expected
OpenJDK 8u275, npn bootstrap 1.9 ... FAIL ... as expected
OpenJDK 8u232, npn bootstrap 1.9.payara-p1 ... SUCCESS
OpenJDK 8u275 ... SUCCESS
OpenJDK 11.0.8 ... SUCCESS

arjantijms commented 3 years ago

npn is not released yet

npn is now staged as 2.0.0, which can be used to do the build

dmatej commented 3 years ago

The build passed locally with profile -Pstaging now, so after npn will make it to Maven Central it should pass now also on Travis :-)