eclipse-ee4j / grizzly

Grizzly
https://eclipse-ee4j.github.io/grizzly
Other
148 stars 69 forks source link

Aggregated fixes from Payara #2112

Closed dmatej closed 3 years ago

dmatej commented 3 years ago

Fixes #2016 and #2111

This is a aggregated PR of Payara's fork of 2.4.4, I hope I didn't skip anything. Current Payara 5.2020.7-SNAPSHOT with these commits in it's own patch of Grizzly passed following tests:

Merge:

dmatej commented 3 years ago

All commits are signed, but eclipsefdn/eca has different opinion - what can I do?

edbratt commented 3 years ago

I agree, it does appear you have signed all the commits and you do have a valid ECA. A committer can go ahead and merge, once a review has been completed.

All commits are signed, but eclipsefdn/eca has different opinion - what can I do?

dmatej commented 3 years ago

I tried even to match my name including czech letters č and ě, but it is still the same. I'm giving up fighting with the eclipsefdn/eca checker ... the PR is prepared to be merged now, I don't plan any other pushes except those which would come from reviews.

dmatej commented 3 years ago

I rebased the PR, the build will now fail here for two reasons:

arjantijms commented 3 years ago

npn is not released yet

npn is now staged as 2.0.0, which can be used to do the build

dmatej commented 3 years ago

The build passed locally with profile -Pstaging now, so after npn will make it to Maven Central it should pass now also on Travis :-)