search

eclipse-ee4j / grizzly

Grizzly
https://eclipse-ee4j.github.io/grizzly
Other
147 stars 69 forks source link

Merge 3.0.0 release in master #2133

Closed arjantijms closed 2 years ago

arjantijms commented 2 years ago

Please update copyright years.

The commit says: "committed on 23 Nov 2020"

So wouldn't it need to be merged in as-is, as those changes were made then?

arjantijms commented 2 years ago

Since I can't edit a PR from another branch directly, I'm closing this, will prepare a 3.0.1 in another branch, and do a PR from that.

dmatej commented 2 years ago

If I remember well, copyright year declares year when the code was created and the copyright license covers the change since that date. So I don't think it is required to change the date, I would even expect it is a wrong idea. Or am I wrong?

m0mus commented 2 years ago

I didn't see that this PR is old. I approve it. But it's already closed...