search

eclipse-ee4j / grizzly

Grizzly
https://eclipse-ee4j.github.io/grizzly
Other
147 stars 69 forks source link

Removed deprecated usages of getPeerCertificateChain #2151

Closed dmatej closed 2 years ago

dmatej commented 2 years ago

A message for the kind reviewer: if you think that it would be good to simply remove those methods now marked as deprecated, I can do that. The SSLSession.getPeerCertificateChain used by the old implementation is not existing in JDK17 any more.

In regard to backward compatibility - calling deprecated methods should be still possible, but implementing the interface means implementing the new version.

Locally all tests passed on JDK11 and JDK17.

arjantijms commented 2 years ago

if you think that it would be good to simply remove those methods now marked as deprecated, I can do that.

Let's leave them in for 1 version, so people who find those methods have disappeared can look at the previous version to see what they moved to.