eclipse-ee4j / grizzly

Grizzly
https://eclipse-ee4j.github.io/grizzly
Other
147 stars 69 forks source link

Grizzly is not compatible with Servlet 6 #2153

Closed jansupol closed 2 years ago

jansupol commented 2 years ago

jakarta.servlet.SingleThreadModel is no longer in Servlet 6 API.

For instance, WebappContext is not compatible with Servlet 6.

arjantijms commented 2 years ago

Thanks for the reminder, that indeed still needs to be done.

That aside, I wonder btw if the half-finished Servlet implementation in Grizzly is really needed still. Is anyone really using this?

jansupol commented 2 years ago

Jersey is using it for the test framework. I think the Jersey test framework is also used by one of the spring boot modules.

arjantijms commented 2 years ago

Interesting. Did you ever try running the Servlet TCK against Grizzly to get an idea what percentage of the Servlet API is implemented?

And just curiously, but was it really the idea to turn Grizzly into a fully compliant Servlet implementation?

jansupol commented 2 years ago

As far as I remember, Alexey implemented just the minimum functionality for mocking the servlet deployment. It was never meant to be a full servlet implementation.

lukasj commented 2 years ago

metro needs grizzly as well in order to be fully buildable from sources, see https://github.com/eclipse-ee4j/metro-wsit/issues/155

smillidge commented 2 years ago

So is this issue just requesting a build with the Servlet API brought up to speed with Servlet 6 i.e. not an implementation but something you can compile against?

lukasj commented 2 years ago

from metro point of view - yes; should there be need for anything specific to be implemented, that can be done once we see real failure (ie metro uses grizzly for tcp level transport)

jansupol commented 2 years ago

This issue is about replacing the Servlet 5 deprecated methods that have been removed in Servlet 6 with methods that are not deprecated.

dmatej commented 2 years ago

Just FYI, I am working on that, I hope I will be able to push (first?) changes today.

dmatej commented 2 years ago

This issue can be closed now