search

eclipse-ee4j / grizzly

Grizzly
https://eclipse-ee4j.github.io/grizzly
Other
147 stars 68 forks source link

Grizzly does not build against Servlet 6.1.0-M1 #2205

Open lukasj opened 5 months ago

lukasj commented 5 months ago 
[ERROR] .../org/glassfish/grizzly/servlet/HttpServletResponseImpl.java:[48,8] org.glassfish.grizzly.servlet.HttpServletResponseImpl is not abstract and does not override abstract method sendRedirect(java.lang.String,int,boolean) in jakarta.servlet.http.HttpServletResponse
lukasj commented 5 months ago

@arjantijms nor M2 - both are missing sendRedirect(java.lang.String,int,boolean) method in org.glassfish.grizzly.servlet.HttpServletResponseImpl - in 4.0.2

arjantijms commented 2 months ago

@lukasj This commit from a while ago should have fixed that:

https://github.com/eclipse-ee4j/grizzly/pull/2209

arjantijms commented 2 months ago

You should then try with 4.1.0-M1, not 4.0.2.

lukasj commented 2 months ago

that commit went to the main branch and the default one is master. What is the point of having main the master without actually renaming the master to main and keeping both branches? Isn't it confusing?

...to answer the 4.1.0-M1 - yes, this version works fine for me.

arjantijms commented 2 months ago

What is the point of having main the master without actually renaming the master to main and keeping both branches? Isn't it confusing?

Still work to be done indeed. It's done now via the self service thing, and I still need to find out where it resides and how it works.

arjantijms commented 2 months ago

...to answer the 4.1.0-M1 - yes, this version works fine for me.

\o/ thanks!

arjantijms commented 2 months ago

Also, maybe we need to move Grizzly to the GlassFish project or I need to nominate some other committers. It seems that now I'm the last active committer there.

dmatej commented 1 month ago

Also, maybe we need to move Grizzly to the GlassFish project or I need to nominate some other committers. It seems that now I'm the last active committer there.

I can join you, I already did some work on Grizzly: https://github.com/eclipse-ee4j/grizzly/issues?q=author%3Admatej If I remember well, when I was working for Payara I also fixed some h2spec tests. Seems those changes are missing in this repo, I have to check ...