redesign so we can remove cometselector

[glassfishrobot]

redesign so we can remove cometselector. status:

seems to work fine for basic tests. more testing is needed. async is untested.

idletimeout config is not yet implemented. need new interface to allow for key specific timeout values. (each cometcontext can have different values) this will lead to the first needed change in the framework module.

problems still not sure if solved:

CometTask during non async read operations adds itself to banned key list, preventing mainkey to become registered. need to think about this one. but it seems we simple can skip the key banning and let the mainselector do the work cometselector did. (attachment interface callback methods allows for that) if its this simple, then the current implementation is allready ok =)

Environment

Operating System: All Platform: All

Affected Versions

[1.9.22]

[glassfishrobot]

• Issue Imported From: https://github.com/javaee/grizzly/issues/409
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @glassfishrobot
• Original Issue Closed By:@glassfishrobot

[glassfishrobot]

@glassfishrobot Commented Reported by gustav3d@java.net

[glassfishrobot]

@glassfishrobot Commented jfarcand@java.net said: The branch is ready, but I propose we release 1.9.5 first then merge.

[glassfishrobot]

@glassfishrobot Commented gustav3d@java.net said: Sending grizzly\trunk\trunk\modules\comet\src\main\java\com\sun\grizzly\comet\CometContext.java Sending grizzly\trunk\trunk\modules\comet\src\main\java\com\sun\grizzly\comet\CometEngine.java Sending grizzly\trunk\trunk\modules\comet\src\main\java\com\sun\grizzly\comet\CometEvent.java Deleting grizzly\trunk\trunk\modules\comet\src\main\java\com\sun\grizzly\comet\CometInputStream.java Deleting grizzly\trunk\trunk\modules\comet\src\main\java\com\sun\grizzly\comet\CometSelector.java Sending grizzly\trunk\trunk\modules\comet\src\main\java\com\sun\grizzly\comet\CometTask.java Sending grizzly\trunk\trunk\modules\comet\src\main\java\com\sun\grizzly\comet\DefaultNotificationHandler.java Sending grizzly\trunk\trunk\modules\grizzly\src\main\java\com\sun\grizzly\CallbackHandlerSelectionKeyAttachment.java Sending grizzly\trunk\trunk\modules\grizzly\src\main\java\com\sun\grizzly\DefaultSelectionKeyHandler.java Sending grizzly\trunk\trunk\modules\grizzly\src\main\java\com\sun\grizzly\suspendable\SuspendableFilter.java Sending grizzly\trunk\trunk\modules\http\src\main\java\com\sun\grizzly\arp\AsyncProtocolFilter.java Sending grizzly\trunk\trunk\modules\http\src\main\java\com\sun\grizzly\http\DefaultProtocolFilter.java Sending grizzly\trunk\trunk\modules\http\src\main\java\com\sun\grizzly\http\SelectorThreadKeyHandler.java Sending grizzly\trunk\trunk\modules\utils\src\main\java\com\sun\grizzly\util\SelectionKeyAttachment.java Transmitting file data ............ Committed revision 2425.

[glassfishrobot]

@glassfishrobot Commented jfarcand@java.net said: There is a major regression with the cometd-client where Request/Response gets corrupted. Rollback to the previous state and we will investigate. I'm not convinced the problem was with this commit but rolling back fix cometd-client

Sending comet/src/main/java/com/sun/grizzly/comet/CometContext.java Sending comet/src/main/java/com/sun/grizzly/comet/CometEngine.java Sending comet/src/main/java/com/sun/grizzly/comet/CometEvent.java Adding comet/src/main/java/com/sun/grizzly/comet/CometInputStream.java Adding comet/src/main/java/com/sun/grizzly/comet/CometSelector.java Sending comet/src/main/java/com/sun/grizzly/comet/CometTask.java Sending comet/src/main/java/com/sun/grizzly/comet/DefaultNotificationHandler.java Transmitting file data ....... Committed revision 2465.

[glassfishrobot]

@glassfishrobot Commented jfarcand@java.net said: Bump millestone

[glassfishrobot]

@glassfishrobot Commented jfarcand@java.net said: Bump version

[glassfishrobot]

@glassfishrobot Commented jfarcand@java.net said: Bump version

[glassfishrobot]

@glassfishrobot Commented gustav3d@java.net said: semi prepared for next patch that will move some IO out from selector thread

Sending java/grizzly/trunk/code/modules/comet/src/main/java/com/sun/grizzly/comet/CometContext.java Sending java/grizzly/trunk/code/modules/comet/src/main/java/com/sun/grizzly/comet/CometEngine.java Sending java/grizzly/trunk/code/modules/comet/src/main/java/com/sun/grizzly/comet/CometEvent.java Sending java/grizzly/trunk/code/modules/comet/src/main/java/com/sun/grizzly/comet/CometHandler.java Deleting java/grizzly/trunk/code/modules/comet/src/main/java/com/sun/grizzly/comet/CometSelector.java Sending java/grizzly/trunk/code/modules/comet/src/main/java/com/sun/grizzly/comet/CometTask.java Sending java/grizzly/trunk/code/modules/comet/src/main/java/com/sun/grizzly/comet/DefaultNotificationHandler.java Sending java/grizzly/trunk/code/modules/comet/src/main/java/com/sun/grizzly/comet/concurrent/DefaultConcurrentCometHandler.java Adding java/grizzly/trunk/code/modules/comet/src/main/resources Sending java/grizzly/trunk/code/modules/comet/src/test/java/com/sun/grizzly/comet/BasicCometTest.java Sending java/grizzly/trunk/code/modules/comet/src/test/java/com/sun/grizzly/comet/CometUnitTest.java Sending java/grizzly/trunk/code/modules/compat/src/main/java/com/sun/enterprise/web/connector/grizzly/comet/CometContext.java Sending java/grizzly/trunk/code/modules/compat/src/main/java/com/sun/enterprise/web/connector/grizzly/comet/CometEngine.java Sending java/grizzly/trunk/code/modules/compat/src/main/java/com/sun/enterprise/web/connector/grizzly/comet/CometEvent.java Adding java/grizzly/trunk/code/modules/compat/src/main/java/com/sun/enterprise/web/connector/grizzly/comet/CometTask.java Sending java/grizzly/trunk/code/modules/compat/src/main/java/com/sun/enterprise/web/connector/grizzly/comet/DefaultNotificationHandler.java Adding java/grizzly/trunk/code/modules/compat/src/main/resources Sending java/grizzly/trunk/code/modules/grizzly/src/main/java/com/sun/grizzly/Controller.java Sending java/grizzly/trunk/code/modules/grizzly/src/main/java/com/sun/grizzly/DefaultProtocolChain.java Sending java/grizzly/trunk/code/modules/grizzly/src/main/java/com/sun/grizzly/SelectorHandler.java Sending java/grizzly/trunk/code/modules/grizzly/src/main/java/com/sun/grizzly/UDPSelectorHandler.java Sending java/grizzly/trunk/code/modules/grizzly/src/test/java/com/sun/grizzly/ControllerStateTest.java Sending java/grizzly/trunk/code/modules/grizzly/src/test/java/com/sun/grizzly/utils/ControllerUtils.java Sending java/grizzly/trunk/code/modules/http/src/main/java/com/sun/grizzly/arp/AsyncProtocolFilter.java Sending java/grizzly/trunk/code/modules/http/src/main/java/com/sun/grizzly/arp/DefaultAsyncExecutor.java Sending java/grizzly/trunk/code/modules/http/src/main/java/com/sun/grizzly/http/KeepAliveThreadAttachment.java Sending java/grizzly/trunk/code/modules/http/src/main/java/com/sun/grizzly/http/ProcessorTask.java Sending java/grizzly/trunk/code/modules/http/src/main/java/com/sun/grizzly/http/SelectorThreadKeyHandler.java Sending java/grizzly/trunk/code/modules/http/src/test/java/com/sun/grizzly/http/SuspendTest.java Sending java/grizzly/trunk/code/modules/http/src/test/java/com/sun/grizzly/http/utils/SelectorThreadUtils.java Adding java/grizzly/trunk/code/modules/rcm/src/main/resources Adding java/grizzly/trunk/code/modules/utils/src/main/java/com/sun/grizzly/tcp/PendingIOhandler.java Sending java/grizzly/trunk/code/modules/utils/src/main/java/com/sun/grizzly/tcp/Response.java Adding java/grizzly/trunk/code/modules/utils/src/main/java/com/sun/grizzly/util/SelectedKeyAttachmentLogic.java Sending java/grizzly/trunk/code/modules/utils/src/main/java/com/sun/grizzly/util/SelectionKeyAttachment.java Sending java/grizzly/trunk/code/modules/utils/src/main/java/com/sun/grizzly/util/ThreadAttachment.java Sending java/grizzly/trunk/code/modules/utils/src/main/java/com/sun/grizzly/util/WorkerThreadImpl.java Transmitting file data ... Committed revision 2836.

[glassfishrobot]

@glassfishrobot Commented gustav3d@java.net said: .

[glassfishrobot]

@glassfishrobot Commented Was assigned to gustav3d@java.net

[glassfishrobot]

@glassfishrobot Commented This issue was imported from java.net JIRA GRIZZLY-409

[glassfishrobot]

@glassfishrobot Commented Marked as fixed on Wednesday, December 16th 2009, 6:13:09 pm