search

eclipse-ee4j / jakartaee-tck-tools

Other
7 stars 15 forks source link

ejblitejsp vehicle archives are missing the WEB-INF/tlds/ejblitejsp.tld #107

Closed starksm64 closed 4 weeks ago

starksm64 commented 4 weeks ago

The ejblitejsp vehicle generated deployment method is not pulling in the WEB-INF/tlds/ejblitejsp.tld. This is another template file that is copied with package replacement and refers to another template class EJBLiteJSPTag.java.txt whose package is also replaced during the copy:

[FINE]13:18:11.943 (TsTaskListener) copy msg: Copying /home/starksm/Dev/Jakarta/wildflytck/jakartaeetck/src/com/sun/ts/tests/common/vehicle/ejblitejsp/ejblitejsp.tld to /home/starksm/Dev/Jakarta/wildflytck/jakartaeetck/dist/com/sun/ts/tests/ejb32/lite/timer/basic/concurrency/ejblitejsp.tld
[FINER]13:18:11.945 (TsTaskListener) Replacing: @package@ -> com.sun.ts.tests.ejb32.lite.timer.basic.concurrency
[FINE]13:18:11.946 (TsTaskListener) copy msg: Copying 1 file to /home/starksm/Dev/Jakarta/wildflytck/jakartaeetck/classes/com/sun/ts/tests/ejb32/lite/timer/basic/concurrency
[FINE]13:18:11.946 (TsTaskListener) copy msg: Copying /home/starksm/Dev/Jakarta/wildflytck/jakartaeetck/src/com/sun/ts/tests/common/vehicle/ejblitejsp/EJBLiteJSPTag.java.txt to /home/starksm/Dev/Jakarta/wildflytck/jakartaeetck/classes/com/sun/ts/tests/ejb32/lite/timer/basic/concurrency/EJBLiteJSPTag.java
[FINER]13:18:11.947 (TsTaskListener) Replacing: @package@ -> com.sun.ts.tests.ejb32.lite.timer.basic.concurrency
starksm64 commented 4 weeks ago

The EJBLiteJSPTag classes have already been migrated to the test source tree, so we just need to include a transformed ejblitejsp.tld

starksm64 commented 4 weeks ago

Unfortunately this is another case of where the ant build copies a file into the dist directory and transforms it, which we can capture, but then it deletes that file so by the time the code generation runs the file it gone. Either we need to add ejblitejsp vehicle specific code to do the same thing, or transform the ejblitejsp.tld into the source tree.