eclipse-ee4j / jakartaee-tck-tools

Other
7 stars 15 forks source link

Syntax error after refactoring all of the jpa tests, the ee.jakarta.tck.persistence.core.entitytest.persist.oneXmany package has a compile error #125

Closed scottmarlow closed 2 weeks ago

scottmarlow commented 2 weeks ago

// The class files jpa_core_types_generator_puservlet_vehicle_web.addClasses( com.sun.ts.tests.common.vehicle.ejb3share.EJB3ShareBaseBean.class, com.sun.ts.tests.common.vehicle.VehicleRunnerFactory.class, com.sun.ts.tests.common.vehicle.ejb3share.UseEntityManager.class, com.sun.ts.tests.common.vehicle.ejb3share.EJB3ShareIF.class, com.sun.ts.tests.common.vehicle.puservlet.PUServletVehicle.class, com.sun.ts.lib.harness.EETest.Fault.class, ee.jakarta.tck.persistence.core.types.generator.Client1.class, com.sun.ts.tests.common.vehicle.ejb3share.UseEntityManagerFactory.class, ee.jakarta.tck.persistence.common.PMClientBase.class, com.sun.ts.tests.common.vehicle.servlet.ServletVehicle.class, com.sun.ts.tests.common.vehicle.VehicleRunnable.class, com.sun.ts.tests.common.vehicle.ejb3share.UserTransactionWrapper.class, com.sun.ts.lib.harness.EETest.class, com.sun.ts.lib.harness.ServiceEETest.class, com.sun.ts.tests.common.vehicle.ejb3share.EntityTransactionWrapper.class, com.sun.ts.lib.harness.EETest.SetupException.class, com.sun.ts.tests.common.vehicle.VehicleClient.class, com.sun.ts.tests.common.vehicle.ejb3share.NoopTransactionWrapper.class, ee.jakarta.tck.persistence.core.types.generator.Client.class );

^ on the last line ee.jakarta.tck.persistence.core.types.generator.Client.class shouldn't be there.

Workaround, instead of refactoring all of the jpa tests, only refactor the ee.jakarta.tck.persistence.core.entitytest.persist.oneXmany package via:

mvn -Dtckpackage=ee.jakarta.tck.persistence.core.entitytest.persist.oneXmany -Pstaging -frewrite-pom.xml -DoverwriteExistingTests=true -Dtcksourcepath=platform-tests/src/main/java -Dts.home=/home/smarlow/tck/tck10/jakartaeetck org.openrewrite.maven:rewrite-maven-plugin:runNoFork 2>&1 | tee /tmp/tck.log

scottmarlow commented 2 weeks ago

Local patch to use snapshot tck-rewrite-ant:

diff --git a/jpa/rewrite-pom.xml b/jpa/rewrite-pom.xml
index b525da9d2..88f999265 100644
--- a/jpa/rewrite-pom.xml
+++ b/jpa/rewrite-pom.xml
@@ -716,7 +716,7 @@
                     <dependency>
                         <groupId>jakarta.tck</groupId>
                         <artifactId>tck-rewrite-tools</artifactId>
-                        <version>1.0.0-M10</version>
+                        <version>1.0.0-SNAPSHOT</version>
                     </dependency>
                     <dependency>
                         <groupId>org.openrewrite</groupId>