eclipse-ee4j / jakartaee-tck-tools

Other
7 stars 15 forks source link

common/src/main/java/tck/arquillian/protocol/common/TsTestPropsBuilder.java is setting wrong test_classname property for ee.jakarta.tck.persistence.core.EntityGraph.ClientPuservletTest #133

Closed scottmarlow closed 1 week ago

scottmarlow commented 2 weeks ago

Instead of setting "test_classname" property to "ee.jakarta.tck.persistence.core.EntityGraph.ClientPuservletTest" we seem to be setting it to the super class ee.jakarta.tck.persistence.core.EntityGraph.Client.

Currently, we set via:

        // The vehicle harness operates on the legacy CTS superclass of the Junit5 class.
        // unless the Junit5 test class directly extends the EETest/ServiceEETest class.
        if(isAbstract(testSuperclass)) {
            props.setProperty("test_classname", testClass.getName());
        } else {
            props.setProperty("test_classname", testSuperclass.getName());
        }

For ee.jakarta.tck.persistence.core.EntityGraph.ClientPuservletTest, we should use the testClass

starksm64 commented 2 weeks ago

That is what is required for most tests and the generated test class is really just a shell that adds the junit test annotations and arquillian deployment method. The real test logic is still in the base class for these tests. With the jpa refactoring, I guess that is not the case. I'll look at the ee.jakarta.tck.persistence.core.EntityGraph.ClientPuservletTest.