search

eclipse-ee4j / jakartaee-tck-tools

Other
7 stars 15 forks source link

Deal with test class file rename #95

Closed starksm64 closed 1 month ago

starksm64 commented 1 month ago

Fixes #91

scottmarlow commented 1 month ago

Thanks, will try this locally.

scottmarlow commented 1 month ago

Comment https://github.com/eclipse-ee4j/jakartaee-tck-tools/issues/91#issuecomment-2278400944 should of been added it here instead.

scottmarlow commented 1 month ago

I will try debugging the addTestClassMapping part of the change to see why we are adding the nested class instead of the "Client" + number class file.

scottmarlow commented 1 month ago

Looks like the problem that I mentioned in https://github.com/eclipse-ee4j/jakartaee-tck-tools/issues/91#issuecomment-2278400944 with the nested class reference is solved by the https://github.com/eclipse-ee4j/jakartaee-tck-tools/pull/90 change, so will reopen that. Thanks for this change!

scottmarlow commented 1 month ago

I'm not actually sure of the other problem yet. Probably nothing to do with https://github.com/eclipse-ee4j/jakartaee-tck-tools/pull/90 but does seem like a nested class issue.

scottmarlow commented 1 month ago

The com.sun.ts.tests.jpa.core.criteriaapi.CriteriaQuery.Client.ExpectedResult.class reference should work if the ee10 package is mapped to the correct ee11 package.

scottmarlow commented 1 month ago

Trying a fix for ^ now

scottmarlow commented 1 month ago

I fixed the problem with nested class package not getting mapped to EE 11 via https://github.com/eclipse-ee4j/jakartaee-tck-tools/pull/96 but still seem to need more changes to use the correct test class name since Client is referenced instead of Client6Stateless3Test in platformtck/jpa/platform-tests/src/main/java/ee/jakarta/tck/persistence/core/criteriaapi/CriteriaQuery/Client6Stateless3Test.java:

ee.jakarta.tck.persistence.core.criteriaapi.CriteriaQuery.Client.ExpectedResult.class

scottmarlow commented 1 month ago

I think that EE11toEE10Mapping#getEE11Name(String ee10Name) needs to handle correcting ee.jakarta.tck.persistence.core.criteriaapi.CriteriaQuery.Client.ExpectedResult.class to ee.jakarta.tck.persistence.core.criteriaapi.CriteriaQuery.Client1.ExpectedResult.class.