search

eclipse-ee4j / jax-rpc-ri

JAX RPC Implementation (Eclipse Metro Project)
Other
2 stars 4 forks source link

Split Impl and SPI into seperate modules #70

Closed Cousjava closed 5 years ago

Cousjava commented 5 years ago

Also added in poms for samples projects

Cousjava commented 5 years ago

@lukasj I've added the relative path in to the install path, mvn clean install -Pstaging works for me

lukasj commented 5 years ago

@Cousjava let me see.... you're right, it builds on 8 which provides 'javax.xml.soap' packages (should likely be passed to the compiler through -Djava.endosed.dirs); on 11 these are not provided so the build fails there; probably not a big deal at this point

what worries me more is that jaxrpc-bundle-1.1.5-SNAPSHOT.zip contains 'target' folders of built samples 0 - these should not be there

it would also be good to define versions for maven-{source,javadoc,enforcer}-plugin to avoid warnings when building using: mvn -U -C clean install -Pstaging,oss-release

and javadoc plugin configuration needs doclint:none for previous command (used to release the project) to work

Cousjava commented 5 years ago

@lukasj I've update my PR with your requested changes

lukasj commented 5 years ago

@Cousjava Thanks! last step is to prepare PR to port this to EE4J_8 branch...