eclipse-ee4j / jaxb-fi

Apache License 2.0
8 stars 10 forks source link

Provide FastInfoset-*-sources.jar required by project eclipse-ee4j/jaxb-ri #114

Closed rsearls closed 8 months ago

rsearls commented 2 years ago

module fastinfoset needs to generate a FastInfoset-*-sources.jar archive. Project https://github.com/eclipse-ee4j/jaxb-ri.git requires this source jar to successfully build module jaxb-ri/bundles/osgi/osgi generated classes.

lukasj commented 2 years ago

Pass -Poss-release to the build to get sources as well as javadoc jars. Or am I missing something?

rsearls commented 2 years ago

@lukasj please clarify your statement above. Is there some action I am to take?

lukasj commented 2 years ago

mvn install -Poss-release

rsearls commented 2 years ago

@lukgpg: "mvn install -Poss-release" does not work for me. I get error. no default secret key: No secret key gpg: signing failed: No secret key

Is this sufficient? mvn install -Poss-release -Dgpg.skip=true -Dcopyright.ignoreyear=true

lukasj commented 2 years ago

what have you tried to resolve this?

see the build command or the documentation of the gpg plugin. One can also set up GPG signing on his end

Is this sufficient? mvn install -Poss-release -Dgpg.skip=true -Dcopyright.ignoreyear=true

copyright.ignoreyear=true is not needed and should not be used locally; the only reason GH action does this is that the "merge" done by the action modifies all files which is wrong, since the PR itself usually changes only a subset of them

rsearls commented 2 years ago

@lukasj OK I created a key and this cmd (mvn install -Poss-release) runs successfully. What next?

lukasj commented 2 years ago

What next?

I don't know. Check the content of target folders or of the local maven repository after running the build to see what is there or see what the failure is? Keep in mind that I'm not sitting next to you nor I can see the output of the build, I don't know which OS/java version/maven version you use etc there are simply too many variables I'm guessing

rsearls commented 2 years ago

There are no build or test failures. The needed --sources.jar. archives are generated and install in my local repo. This looks good to me.

lukasj commented 8 months ago

closing per the last comment