search

eclipse-ee4j / krazo

Apache License 2.0
52 stars 19 forks source link

eclipse-ee4j/krazo#282: Added HttpCommunicationWrapper for Liberty JEE9 #288

Closed jesse-gallagher closed 2 years ago

jesse-gallagher commented 2 years ago

This change should fix the trouble observed in https://github.com/eclipse-ee4j/krazo/issues/282 , allowing Krazo to work again on Liberty JEE 9 betas.

The test suites for WildFly and GlassFish should still pass without issue, but there's one test failure in Liberty. I believe it's unrelated to this change, though, and I'll create another issue to identify the trouble there.

erdlet commented 2 years ago

Thanks @jesse-gallagher for submitting this PR! :)

jesse-gallagher commented 2 years ago

Done on both counts. I bumped the copyright year, changed the catch to only catch explicitly-thrown exceptions, and also added some requireNonNull lines on retrieved objects with explanatory messages.

erdlet commented 2 years ago

Thanks! Looks good to me.

chkal commented 2 years ago

@jesse-gallagher I'm a bit late, but anyway: Thanks for contributing this patch! :beers: