eclipse-ee4j / krazo

Apache License 2.0
52 stars 19 forks source link

Implement specified form method overwrite #296

Closed erdlet closed 2 years ago

erdlet commented 2 years ago

This PR implements the newly specified feature 'form method overwrite' and fixes the TCK runner for WildFly on higher JDKs.

As Glassfish ships with a other version of Krazo, the TCK failed there. On WildFly 26 everything went fine. I'd recommend to release a Krazo milestone afterwards which maybe can be put into the Glassfish Beta, so we can test against it.

erdlet commented 2 years ago

I think it makes sense to release a milestone for the TCK first, so I have a version to set in the POM to fix the build.

chkal commented 2 years ago

Update: The CI build currently still fails because of the TCK version.

ivargrimstad commented 2 years ago

I think it makes sense to release a milestone for the TCK first, so I have a version to set in the POM to fix the build.

With release, you mean to staging? I don't see need to publish a milestone to central.

erdlet commented 2 years ago

With release, you mean to staging?

Yes, I thought in Maven terms ;)

erdlet commented 2 years ago

The TCK is now staged in Nexus and the build should run again.