search

eclipse-ee4j / krazo

Apache License 2.0
50 stars 19 forks source link

Added HttpCommunicationWrapper for Liberty Jakarta EE 10 #365

Closed mthmulders closed 1 year ago

mthmulders commented 1 year ago

Follow-up on #364. This change gets Krazo working on OpenLiberty 22.0.0.13-beta with Jakarta EE 10.

I have added the HttpCommunicationWrapper next to the existing one, introduced in #288. I don't know if they should live together, or if this one should replace the previous one. When living together, I'm not sure about the priority of one vs. the other.

erdlet commented 1 year ago

Thanks for the contribution! I try to run the code against the testsuite within the next days to check if / how we should proceed with the two unwrapper implementations. The code itself looks good👍🏻

chkal commented 1 year ago

@mthmulders Thanks a lot for sharing this solution. It would be great if we could improve compatibility with OpenLiberty which such a workaround. Also, it looks to me as if the actual root cause should be fixed on the OpenLiberty side. Maybe we are lucky and OpenLiberty/open-liberty#23774 will be fixed soon.

erdlet commented 1 year ago

@mthmulders sorry for the delay. I had to get the testsuite for OL working again. But it seems that this workaround is working great and as soon as the testsuite is merged to master we can merge this PR as well. There will be still test failures, but those are related to some OL internal problems or issues we still have to investigate.