eclipse-ee4j / metro-jax-ws

metro-jax-ws
https://eclipse-ee4j.github.io/metro-jax-ws/
BSD 3-Clause "New" or "Revised" License
72 stars 40 forks source link

HttpTransportPipe dump - improve logging on empty header values #627

Closed s-lindenau closed 1 year ago

s-lindenau commented 2 years ago

https://github.com/eclipse-ee4j/metro-jax-ws/blob/5c1c438ba09b2eef8ad38834b92c3129e2a9c981/jaxws-ri/runtime/rt/src/main/java/com/sun/xml/ws/transport/http/client/HttpTransportPipe.java#L431

The dump logging will print all headers, but if somehow there is a header (key) in there with an empty list of values, that empty list is printed. Would it not make more sense to also print the key in that case, so you know which headers are empty?

If i inject a fake header that meets this criteria via a debugger session, we can see in the logging that the key "Test" is missing: jaxws-dump-headers

jaxws-dump-log