PartialTraversalViewRootHelper breaks with apache MyFacces

[glassfishrobot]

Contrary to the FAQ "What is the Relationship Between jsf-extensions and the Glassfish Project?", the PartialTraversalViewRootHelper class does leverage an implementation specific detail when it does that nasty "getBroadcastEventsMethod()" bit. Now that MyFaces also implements the JSF 1.2 standard (and is installed as the default JSF impl on Geronimo, IBM WebSphere), it would be nice if this jsf-extensions library also worked correctly with it. I haven't tested this, but as a quick fix it looks like the MyFaces equivalent to UIViewRoot method: private void broadcastEvents(FacesContext context, PhaseId phaseId) would be: private void _broadcastForPhase(PhaseId phaseId) So the getBroadcastEventsMethod() could look for either. The calling code would have to allow for the one-less parameter also.

Of course, if you fix this, I don't know if there are any other incompatibilities. Ultimately not having to rely on private methods has to be better too. If there is a functionality gap, then perhaps the JSF API spec needs to be tweeked to include such a method.

Environment

Operating System: All Platform: All

Affected Versions

[current]

[glassfishrobot]

• Issue Imported From: https://github.com/javaee/jsf-extensions/issues/89
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @glassfishrobot

[glassfishrobot]

@glassfishrobot Commented Reported by tony_robertson

[glassfishrobot]

@glassfishrobot Commented Was assigned to jsf-extensions-issues

[glassfishrobot]

@glassfishrobot Commented This issue was imported from java.net JIRA JSF_EXTENSIONS-89