Closed ren-zhijun-oracle closed 11 years ago
@javaserverfaces Commented Reported by rogerk
@javaserverfaces Commented @edburns said: We resolved in the Mojarra Engineering meeting to make a new concrete impl private component with
component-type: javax.faces.Panel with renderer-type: javax.faces.passthrough.Element
This new component must be a ClientBehaviorHolder.
@javaserverfaces Commented @edburns said: RK> SECTION: Modified Files RK> ---------------------------- RK> M jsf-ri/src/main/java/com/sun/faces/facelets/tag/jsf/PassThroughElementComponentHandler.java RK> ---- Override hook method createComponent to create an instance of the PassthroughElement
I think we have some code in com.sun.faces.Util that deals with ClassLoaders and you should be using that to create classes, or at least use the ClassLoader you get from that to pass to Class.forName(). In any case, I'm pretty sure just straight-up Class.forName() is not a good idea. Most of the other usages of Class.forName() in mojarra pass the ClassLoader argument.
RK> ---- component class. RK> M jsf-ri/src/main/java/com/sun/faces/renderkit/html_basic/PassthroughRenderer.java RK> ---- call RenderKitUtils.renderPassThruAttributes so that Ajax behavior markup is enabled. RK> M test/agnostic/renderKit/passthrough/src/main/webapp/fieldset.xhtml RK> M test/agnostic/renderKit/passthrough/src/main/webapp/label.xhtml RK> ---- Test pages
RK> A jsf-ri/src/main/java/com/sun/faces/component/PassthroughElement.java RK> ---- Component used for pass through elements. RK> A test/agnostic/renderKit/passthrough/src/test/java/com/sun/faces/test/agnostic/renderKit/passthrough/Issue2629IT.java RK> ---- Test case driver.
Otherwise looks good. r=edburns. I'm going to take the liberty to forward this changebundle to Frank Caputo who wrote most of the passthrough element feature so he has a chance to review it.
Ed
@javaserverfaces Commented rogerk said: Committed to trunk:
Adding jsf-ri/src/main/java/com/sun/faces/component/PassthroughElement.java Sending jsf-ri/src/main/java/com/sun/faces/facelets/tag/jsf/PassThroughElementComponentHandler.java Sending jsf-ri/src/main/java/com/sun/faces/renderkit/html_basic/PassthroughRenderer.java Sending test/agnostic/renderKit/passthrough/src/main/webapp/fieldset.xhtml Sending test/agnostic/renderKit/passthrough/src/main/webapp/label.xhtml Adding test/agnostic/renderKit/passthrough/src/test/java/com/sun/faces/test/agnostic/renderKit/passthrough/Issue2629IT.java Transmitting file data ...... Committed revision 11290.
@javaserverfaces Commented rogerk said: Committed.
@javaserverfaces Commented Parent-Task: JAVASERVERFACES-2512
@javaserverfaces Commented Was assigned to rogerk
@javaserverfaces Commented This issue was imported from java.net JIRA JAVASERVERFACES-2629
@javaserverfaces Commented Marked as fixed on Thursday, December 20th 2012, 12:44:06 pm
HTML5 passthrough elements such as