search

eclipse-ee4j / mojarra

Mojarra, a Jakarta Faces implementation
Other
163 stars 111 forks source link

Various Javadoc fixes #5115

Closed Emkas closed 2 years ago

Emkas commented 2 years ago
melloware commented 2 years ago

Thank you for all these PR's cleaning up!

Emkas commented 2 years ago

Thank you for all these PR's cleaning up!

You're all welcome :-) I've got many more of it.

When I've imported this project to eclipse I saw a sea of various warnings (more than 2k). And I don't like that :-) Mostly they are about raw types. Lack of them creates a space where there are test that are basically checking if raw types in Java works (like fail(Should have thrown ClassCastException)). I suspect that this is because the roots of the project remembers Java 4.

But I need more time on this, since I need to figure out which changes concert api and which are internal. I want to touch only the second ones. (And I hope that tests coverage in this project is good enough :-) Since I base mostly on them.)

arjantijms commented 2 years ago

When I've imported this project to eclipse I saw a sea of various warnings (more than 2k).

That's true. We've been addressing a number of them throughout the years, but there's more to be done as you noticed. If you really want to see a lot of those, just take a look at the 2.2 version of the sources :O

arjantijms commented 2 years ago

And I hope that tests coverage in this project is good enough

There's a large number of tests indeed, but we moved them to the jakarta/faces project. It are nearly 6000, and they take some 2 hours to run.

Emkas commented 2 years ago

There's a large number of tests indeed, but we moved them to the jakarta/faces project. It are nearly 6000, and they take some 2 hours to run.

Great! Lesser chance that I'll break something.

For now I get rid of about half of the warnings, but not all of them are as trivial as I thought in the first glance :-)