eclipse-ee4j / mojarra

Mojarra, a Jakarta Faces implementation
Other
160 stars 109 forks source link

Faces.js and Maven compressor #5124

Closed pizzi80 closed 2 years ago

pizzi80 commented 2 years ago

As promised a long time ago, this is my contribution to Mojarra: This is a first release which can be used as a base for further code cleanups and optimizations.

Maven

  1. Removed yuicompressor (dead project with no support for ES6+ js)
  2. Added Google Closure maven plugin for minification https://github.com/blutorange/closure-compiler-maven-plugin

Faces JS

  1. tested and minified with ECMASCRIPT5_STRICT profile of Google Closure
  2. use strict
  3. const and let instead of var
  4. Removed IE-5-6-7-8-9-10 support
  5. Removed IE 5-6-7 hacks and memory hacks
  6. Removed FrameTransport
  7. FormData for File upload
  8. Many minor optimizations
  9. Removed / Commented out unused and very old functions
  10. ~ 10 kB Minified and Gzipped

5045

5040

sorry if I made some mistake with PR or similar... I'm not used to contribute to open source github projects

melloware commented 2 years ago

This looks great but it looks like you need to sign the legal agreement and then watch this video how to fix this PR with your signature! https://www.youtube.com/watch?v=YdJyJpT7rrs

pizzi80 commented 2 years ago

https://github.com/jakartaee/faces/issues/1598

pizzi80 commented 2 years ago

This looks great but it looks like you need to sign the legal agreement and then watch this video how to fix this PR with your signature! https://www.youtube.com/watch?v=YdJyJpT7rrs

I've created an Eclispe account wired with this github account ... I need to follow the instructions on the video... ;)

pizzi80 commented 2 years ago

@melloware I was not sure if it was better to remove everything or not... it's a 3kLOC single file full of hacks..... now that you told me to remove everything, tomorrow I will continue to work on it 😉😉

melloware commented 2 years ago

To me I hate leaving dead blocks of code. That is what Git history is for!