search

eclipse-ee4j / mojarra

Mojarra, a Jakarta Faces implementation
Other
163 stars 111 forks source link

Mocks clean up #5146

Closed Emkas closed 2 years ago

Emkas commented 2 years ago

After this PR I will be able to say that I reduced number of warnings by half. (Only 1,2 k left :dancers:)

BalusC commented 2 years ago

Build failed after merge: https://github.com/eclipse-ee4j/mojarra/runs/7129295931?check_suite_focus=true#step:4:1585

Error: COMPILATION ERROR : [INFO] ------------------------------------------------------------- Error: /home/runner/work/mojarra/mojarra/impl/src/test/java/jakarta/faces/component/NamingContainerTestCase.java:[66,48] incompatible types: java.util.Map<capture#1 of ?,capture#2 of ?> cannot be converted to java.util.Map<java.lang.String,java.lang.String>

Can you take a look?

Emkas commented 2 years ago

Sure. Sorry, I thought I run mvn clean install...

BalusC commented 2 years ago

Most probably not upmerged with most recent from master before PR was merged. Currently the source branch says it is 3 commits behind master.

Emkas commented 2 years ago

Fixed in #5147.