search

eclipse-ee4j / mojarra

Mojarra, a Jakarta Faces implementation
Other
160 stars 109 forks source link

Update HtmlLibrary.java #5185

Closed eproffit2 closed 1 year ago

eproffit2 commented 1 year ago

Fix for issue https://github.com/eclipse-ee4j/mojarra/issues/5182. Doctype if of type HtmlDoctype.COMPONENT_TYPE in JSF 4.0.

BalusC commented 1 year ago

Hi, change looks good but you should have branched off from 4.0 not from master. Master is for Faces.next.

BalusC commented 1 year ago

Declining PR because:

I've fixed in 4.0 via https://github.com/eclipse-ee4j/mojarra/commit/c3288c35343788301ec7c06243c7701badfb873c