search

eclipse-ee4j / mojarra

Mojarra, a Jakarta Faces implementation
Other
160 stars 109 forks source link

Add back id attribute to VDL of h:head and h:body #5186

Closed BalusC closed 1 year ago

BalusC commented 1 year ago

https://github.com/jakartaee/faces/issues/1760

BalusC commented 1 year ago

Ran entire tck localhost as well, all green.

BalusC commented 1 year ago

Thomas can you review at least the spec change in taglib? https://github.com/eclipse-ee4j/mojarra/pull/5186/files#diff-a977313af2132f4b6dc25adc6bd8719a6822c5ae62ef547d1d7d82bbdc0baab3 Importantingly whether the wording "The attribute is only rendered when the current doctype is a HTML5 doctype" is clear enough for MyFaces to do the same.

BalusC commented 1 year ago

@tandraschko can you please review?

melloware commented 1 year ago

I know he is on holiday but i think he is back sometime next week.

tandraschko commented 1 year ago

@BalusC i wonder why this was removed in general?

In MyFaces it looks like we always render the head/body id if specified by the user, doent matter if html5 or not. Thats sounds correct to me.

BalusC commented 1 year ago

It was accidentally removed, see also https://github.com/jakartaee/faces/issues/1760#issuecomment-1349635281

BalusC commented 1 year ago

Ok I've inferred your comment as approval, Thomas. Hereby merged! :)