search

eclipse-ee4j / mojarra

Mojarra, a Jakarta Faces implementation
Other
159 stars 109 forks source link

View maps entries are not restored in "finally" block #5234

Closed santoszv closed 1 year ago

santoszv commented 1 year ago

View maps entries are not restored in "finally" block of method "ViewMetadataImpl.createMetadataView" because "currentViewMapShallowCopy" is always empty

BalusC commented 1 year ago

Can you the next time please target exactly the branch of the version you want to see this fixed in? This PR is currently targeting master instead of 4.0 where the first occurrence of the bug is.

BalusC commented 1 year ago

@arjantijms FYI: this was thus a regression introduced in https://github.com/eclipse-ee4j/mojarra/commit/ebf6a08c2fa8166aac3dbe32da0242e68495433f#diff-c73ecc7df840224c9e86287fdc64900a282fa24f60a2da13d3606d140572a2dfL102 I'll assume that this was just an oversight and thus not intentional.

BalusC commented 1 year ago

Cherry picked for 4.0 via https://github.com/eclipse-ee4j/mojarra/commit/40b84416b154196c4525b21c58bcb380cad00420

BalusC commented 1 year ago

All good now. Thank you very much for creating the PR and improving Mojarra!