search

eclipse-ee4j / mojarra

Mojarra, a Jakarta Faces implementation
Other
158 stars 108 forks source link

Not honoring value of -1 for the jakarta.faces.FACELETS_BUFFER_SIZE application parameter #5262

Closed jamezp closed 1 year ago

jamezp commented 1 year ago

In https://github.com/eclipse-ee4j/mojarra/issues/5164 a change was made to honor the default value of 1024. However, the spec also states:

A value of -1 will not assign a buffer size on the response.

This does not seem to be implemented and is just passed to the HttpServletResponse.

A clear and concise description of what the bug is.

To Reproduce

Steps to reproduce the behavior:

  1. Set the context parameter of jakarta.faces.FACELETS_BUFFER_SIZE to -1.

Expected behavior

The value should not be set on the jakarta.servlet.http.HttpServletResponse.

Additional context

This fails on WildFly as it tries to allocate a buffer size of less than 0.

jamezp commented 1 year ago

If there is a different PR required to get this into 4.0.x let me know and I can create another one.

fjuma commented 1 year ago

@jamezp I think a PR is also needed against the https://github.com/eclipse-ee4j/mojarra/tree/4.0 branch.

jamezp commented 1 year ago

@jamezp I think a PR is also needed against the https://github.com/eclipse-ee4j/mojarra/tree/4.0 branch.

Done #5268